[GitHub] [fineract] vorburger commented on a change in pull request #916: FINERACT-942 Added and Enforced EmptyCatchBlock checkstyle

[GitBox <gi...@apache.org>]

vorburger commented on a change in pull request #916:
URL: https://github.com/apache/fineract/pull/916#discussion_r436311101



##########
File path: fineract-provider/config/checkstyle/checkstyle.xml
##########
@@ -35,10 +35,10 @@
         <property name="format" value="\s+$"/>
         <property name="message" value="Line has trailing spaces."/>
     </module>
-    <module name="RegexpMultiline">
+    <!-- <module name="RegexpMultiline">

Review comment:
       why comment this out here for making this change?

##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/sms/service/SmsCampaignDropdownReadPlatformServiceImpl.java
##########
@@ -81,6 +83,9 @@ public SmsCampaignDropdownReadPlatformServiceImpl(final SmsConfigUtils smsConfig
             if (!responseOne.getStatusCode().equals(HttpStatus.OK)) {
             }
         } catch (Exception e) {
+            //Developer was too lazy to figure out whwat can go wrong?

Review comment:
       you could already change this now? (or later, up to you; later is perfectly fine with me too)

##########
File path: fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountWritePlatformServiceJpaRepositoryImpl.java
##########
@@ -184,6 +184,9 @@ private void validateForAttachedProduct(Long glAccountId) {
                 throw new GLAccountDisableException();
             }
         } catch (EmptyResultDataAccessException e) {
+            // EmptyResultDataAccessException is thrown when more than one row is returned by queryForObject()
+            // count(*) Enforces the return of a single row and hence we should never arrive in this catch block
+            logger.error("Problem encountered in validateForAttachedProduct()",e);

Review comment:
       :+1: 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org