You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Colin Goodheart-Smithe (JIRA)" <ji...@apache.org> on 2011/07/21 14:25:58 UTC
[jira] [Created] (ZOOKEEPER-1130) Java port of PHunt's zk-smoketest
Java port of PHunt's zk-smoketest
---------------------------------
Key: ZOOKEEPER-1130
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
Project: ZooKeeper
Issue Type: New Feature
Components: contrib
Affects Versions: 3.4.0
Reporter: Colin Goodheart-Smithe
Assignee: Colin Goodheart-Smithe
Fix For: 3.4.0
I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Patrick Hunt (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176372#comment-13176372 ]
Patrick Hunt commented on ZOOKEEPER-1130:
-----------------------------------------
4) I just noticed that tabs were used instead of spaces - we only use spaces in code for indentation. Please fix this as well (change config in eclipse and reformat the entire subdir is the easiest way to do it)
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.5.0
>
> Attachments: zk-smoketest.patch, zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069105#comment-13069105 ]
Eugene Koontz commented on ZOOKEEPER-1130:
------------------------------------------
Hi Colin, you are right; most of those files aren't your fault. The problem is that your patch increases the release audit problems count by 2 (from 24 to 26):
"The applied patch generated 26 release audit warnings (more than the trunk's current 24 warnings)."
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/406//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
So you have to find out what are the two files that your patch adds causing those 2 extra warnings.
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.4.0
>
> Attachments: zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1130) Java port of PHunt's zk-smoketest
Posted by "Colin Goodheart-Smithe (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Goodheart-Smithe updated ZOOKEEPER-1130:
----------------------------------------------
Attachment: zk-smoketest.patch
Resubmitted patch
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.5.0
>
> Attachments: zk-smoketest.patch, zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176622#comment-13176622 ]
Hadoop QA commented on ZOOKEEPER-1130:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12508751/zk-smoketest.patch
against trunk revision 1225108.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/865//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/865//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/865//console
This message is automatically generated.
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.5.0
>
> Attachments: zk-smoketest.patch, zk-smoketest.patch, zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069123#comment-13069123 ]
Eugene Koontz commented on ZOOKEEPER-1130:
------------------------------------------
I found a way to find out the "baseline" set of 24 warnings:
https://builds.apache.org/view/S-Z/view/ZooKeeper/job/PreCommit-ZOOKEEPER-Build/lastSuccessfulBuild/artifact/trunk/patchprocess/patchReleaseAuditWarnings.txt
(note the "lastSuccessfulBuild" which means the last build that didn't have any problems, including not
increasing the number of ReleaseAuditProblems).
Then search for "????" which is used for these licensing issue warnings.
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.4.0
>
> Attachments: zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069691#comment-13069691 ]
Hadoop QA commented on ZOOKEEPER-1130:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12487292/zk-smoketest.patch
against trunk revision 1148553.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
-1 release audit. The applied patch generated 26 release audit warnings (more than the trunk's current 24 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/408//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/408//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/408//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/408//console
This message is automatically generated.
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.4.0
>
> Attachments: zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Colin Goodheart-Smithe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069097#comment-13069097 ]
Colin Goodheart-Smithe commented on ZOOKEEPER-1130:
---------------------------------------------------
Yeah I saw that but the files that it is listing are not files that are in my patch (my patch only adds files to src/contrib/zk-smoketest and does not modify any existing files). Furthermore if ytou look at the report from the previous build (https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/405//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt) it lists the same files as problems (plus some more)
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.4.0
>
> Attachments: zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1130) Java port of PHunt's zk-smoketest
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1130:
-------------------------------------
Fix Version/s: (was: 3.4.0)
3.5.0
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.5.0
>
> Attachments: zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1130) Java port of PHunt's zk-smoketest
Posted by "Colin Goodheart-Smithe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Goodheart-Smithe updated ZOOKEEPER-1130:
----------------------------------------------
Attachment: zk-smoketest.patch
Patch file for java port of zk-smoketest
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.4.0
>
> Attachments: zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Colin Goodheart-Smithe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178461#comment-13178461 ]
Colin Goodheart-Smithe commented on ZOOKEEPER-1130:
---------------------------------------------------
Patrick,
I don't see these NPE's on my environment. I am running on windows 7, JDK 1.6_u27 and running from the latest trunk version.
Is there anything in the ZooKeeper Client that would affect the way the watcher events are fired?
Could you run it again with the -v (verbose) option? It might help highlight where the issue is.
Also, does this happen every time you run the smoketest? does it happen when you run the latencies test as well?
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1130.patch, zk-smoketest.patch, zk-smoketest.patch, zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Colin Goodheart-Smithe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069116#comment-13069116 ]
Colin Goodheart-Smithe commented on ZOOKEEPER-1130:
---------------------------------------------------
I have just check through the patch file ui submitted and every fuile has the apache licence header except the README file and I jhave noted that some of the README files in other contrib project do not have it at the top so I am assuming it is ok for README files to not contain the licence header.
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.4.0
>
> Attachments: zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068970#comment-13068970 ]
Hadoop QA commented on ZOOKEEPER-1130:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12487292/zk-smoketest.patch
against trunk revision 1148553.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
-1 release audit. The applied patch generated 26 release audit warnings (more than the trunk's current 24 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/406//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/406//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/406//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/406//console
This message is automatically generated.
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.4.0
>
> Attachments: zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1130) Java port of PHunt's zk-smoketest
Posted by "Patrick Hunt (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1130:
------------------------------------
Attachment: ZOOKEEPER-1130.patch
Updated patch, fixes more tab issues, small tweak to the ivy file, fixed build problems.
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1130.patch, zk-smoketest.patch, zk-smoketest.patch, zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071802#comment-13071802 ]
Mahadev konar commented on ZOOKEEPER-1130:
------------------------------------------
Moving this to 3.5. Its not a blocker.
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.5.0
>
> Attachments: zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Colin Goodheart-Smithe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069064#comment-13069064 ]
Colin Goodheart-Smithe commented on ZOOKEEPER-1130:
---------------------------------------------------
Looking at the release audit warnings I cant see anything that would have been caused by my patch since my patch is confined to its own contrib folder but if you can see a problem with my patch please let me know
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.4.0
>
> Attachments: zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1130) Java port of PHunt's zk-smoketest
Posted by "Colin Goodheart-Smithe (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Goodheart-Smithe updated ZOOKEEPER-1130:
----------------------------------------------
Attachment: zk-smoketest.patch
New patch file with changes for everything asked for. For the dependencies in the ivy file and scripts I have made the changes and I think they are OK, however I do not currently have a Linux build so I cannot run the package target in the main ant build script to fully test this (the build required 'touch' so will not ruin on windows).
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.5.0
>
> Attachments: zk-smoketest.patch, zk-smoketest.patch, zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Colin Goodheart-Smithe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069113#comment-13069113 ]
Colin Goodheart-Smithe commented on ZOOKEEPER-1130:
---------------------------------------------------
What do I compare to though? Like I said before the warnings in that file list the same files as the previous build (although the previous build has some extra ones) and my patch doesnt touch anything outside of src/zk-smoketest. Where can i find the list of the 24 warnings from trunk so i know which 2 it thinks ive added? Ive looked in the zookeeper trunk build artifacts but the ReleaseAuditProblems file doesnt seem to be there.
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.4.0
>
> Attachments: zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Eugene Koontz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069083#comment-13069083 ]
Eugene Koontz commented on ZOOKEEPER-1130:
------------------------------------------
Hi Colin, I found the problem:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/406//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
"Lines that start with ????? in the release audit report indicate files that do not have an Apache license header."
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.4.0
>
> Attachments: zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176262#comment-13176262 ]
Hadoop QA commented on ZOOKEEPER-1130:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12508694/zk-smoketest.patch
against trunk revision 1222816.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/860//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/860//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/860//console
This message is automatically generated.
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.5.0
>
> Attachments: zk-smoketest.patch, zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1130) Java port of PHunt's
zk-smoketest
Posted by "Colin Goodheart-Smithe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069129#comment-13069129 ]
Colin Goodheart-Smithe commented on ZOOKEEPER-1130:
---------------------------------------------------
Thanks for the advice.
I looked through that output for ???? but only found 21 of them. Comparing this to the lines in my build (https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/406//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt), I see the same 21 files plus 5 files from 'src/c' which my patch definitely does not modify. I don't see how my patch could have caused this.
Also if you look at the equivalent file in builds 405, 404, and 404, all 26 files are reported as problems for those builds as well. Are you sure the baseline is correct? it seems strange that 4 seemingly unrelated patches are failing with exactly the same files even though 2 of the builds contain more files then the 26
> Java port of PHunt's zk-smoketest
> ---------------------------------
>
> Key: ZOOKEEPER-1130
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1130
> Project: ZooKeeper
> Issue Type: New Feature
> Components: contrib
> Affects Versions: 3.4.0
> Reporter: Colin Goodheart-Smithe
> Assignee: Colin Goodheart-Smithe
> Fix For: 3.4.0
>
> Attachments: zk-smoketest.patch
>
>
> I have ported Patrick's zookeeper smoke test to Java so that it can be run on windows machines (since I couldn't find any way of getting the python bindings for windows). The port provides the same functionality as the python varient as of 21st June 2011.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira