[GitHub] [kafka] ableegoldman commented on a change in pull request #10407: KAFKA-12523: handle TaskCorruption for revoked tasks & remove commit in handleCorruption

[GitBox <gi...@apache.org>]

ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r601981022



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##########
@@ -167,18 +167,7 @@ void handleCorruption(final Set<TaskId> corruptedTasks) {
             }
         }
 
-        // Make sure to clean up any corrupted standby tasks in their entirety before committing
-        // since TaskMigrated can be thrown and the resulting handleLostAll will only clean up active tasks
         closeAndRevive(corruptedStandbyTasks);
-
-        commit(tasks()

Review comment:
       @guozhangwang I traced all the way back to where this TaskCorrupted logic was initially added in [#8058](https://github.com/apache/kafka/pull/8058) and re-read the relevant discussions, and AFAICT there was never an explicit reason for committing. I guess we just never questioned it since the beginning.
   
   (In fact it seems to have only ever caused problems: eg [KAFKA-10144](https://issues.apache.org/jira/browse/KAFKA-10144))




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org