You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2015/09/01 03:48:38 UTC
Review Request 37985: HIVE-11705 refactor SARG stripe filtering for
ORC into a method
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37985/
-----------------------------------------------------------
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 8c138b9
ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java e034650
Diff: https://reviews.apache.org/r/37985/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 37985: HIVE-11705 refactor SARG stripe filtering
for ORC into a method
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Sept. 5, 2015, 1:59 a.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 272
> > <https://reviews.apache.org/r/37985/diff/2/?file=1061874#file1061874line272>
> >
> > Who calls this method? If this is required later can you put this in that patch. Focus only on refactoring in this patch. Easy to review too :)
it's called from ORC splits and metastore logic in subsequent patches. If patches were all merged the final patch would be too epic
> On Sept. 5, 2015, 1:59 a.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 363
> > <https://reviews.apache.org/r/37985/diff/2/?file=1061874#file1061874line363>
> >
> > I think this is messed up from the beginning. The second argument is list of all projected column names and not just sarg column names. So rename of this method will be helpful.
this is an existing method. One of the reasons for this patch is that it's messed up ;)
> On Sept. 5, 2015, 1:59 a.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 1439
> > <https://reviews.apache.org/r/37985/diff/2/?file=1061874#file1061874line1439>
> >
> > where is this used? I don't see it being used anywhere. Can this be moved to relevant jira?
future metastore usage
> On Sept. 5, 2015, 1:59 a.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java, line 1228
> > <https://reviews.apache.org/r/37985/diff/2/?file=1061876#file1061876line1228>
> >
> > indexInSourceTable will never be null. Right?
it will be, for partition columns and stuff. At least some code that I was reading handles this case
> On Sept. 5, 2015, 1:59 a.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java, line 1231
> > <https://reviews.apache.org/r/37985/diff/2/?file=1061876#file1061876line1231>
> >
> > Whats this translation doing exactly?
> > Is this trying to map between sarg column -> table column index -> orc internal column index?
It's making SARG halfway self contained by replacing columns by their indexes in the table. Then ORC can translate from those to ORC internal indexes
> On Sept. 5, 2015, 1:59 a.m., Prasanth_J wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java, line 517
> > <https://reviews.apache.org/r/37985/diff/2/?file=1061879#file1061879line517>
> >
> > Create a bug?
removed comment instead :)
> On Sept. 5, 2015, 1:59 a.m., Prasanth_J wrote:
> > serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java, line 146
> > <https://reviews.apache.org/r/37985/diff/2/?file=1061881#file1061881line146>
> >
> > I also don't understand why would it contain duplicates. IIRC, this was probably caused by multiple concatenation to the READ_COLUMN_IDS_CONF_STR. I am not sure if this happens anymore, in any case we should create a bug and remove this code. Or may be remove in the next patch. Also use, guava Splitter.splitToList?
existing code :) I added logging as per some other comment
> On Sept. 5, 2015, 1:59 a.m., Prasanth_J wrote:
> > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java, line 28
> > <https://reviews.apache.org/r/37985/diff/2/?file=1061882#file1061882line28>
> >
> > I would prefer setting new name based on internal column names.
> > For example:
> > Schema from filedump: struct<_col0:tinyint,_col1:smallint>
> >
> > Current SARG: leaf-0 = (EQUALS i1 100)
> >
> > After this patch: leaf-0 = (EQUALS _col1 100)
> >
> > If we can map to internal names, the it will be easy to map sarg column names to internal column index. i1 -> 1 (after ripping off _col)
how can we map to internal column name? We are working against a file we have not read (in split generation), these names could be anything
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37985/#review97837
-----------------------------------------------------------
On Sept. 2, 2015, 1:06 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37985/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 1:06 a.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 05efc5f
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSerde.java 8beff4b
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java fcb3746
> ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ProjectionPusher.java 4480600
> ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java e034650
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java 2dc15f9
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b809a23
> serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java 10086c5
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java 0778935
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java d27ac16
>
> Diff: https://reviews.apache.org/r/37985/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 37985: HIVE-11705 refactor SARG stripe filtering
for ORC into a method
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37985/#review97837
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 272)
<https://reviews.apache.org/r/37985/#comment153887>
Who calls this method? If this is required later can you put this in that patch. Focus only on refactoring in this patch. Easy to review too :)
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 275)
<https://reviews.apache.org/r/37985/#comment153888>
Split into two assignments?
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 284)
<https://reviews.apache.org/r/37985/#comment153885>
Split statement?
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 348)
<https://reviews.apache.org/r/37985/#comment153877>
nit: rename to neededColumnNames?
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 362)
<https://reviews.apache.org/r/37985/#comment153880>
I think this is messed up from the beginning. The second argument is list of all projected column names and not just sarg column names. So rename of this method will be helpful.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 378)
<https://reviews.apache.org/r/37985/#comment153881>
Same naming confusion here.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 388)
<https://reviews.apache.org/r/37985/#comment153875>
This function name is misleading. This config represents the columns that are needed to be read not necessarily the column names in the SARG. SARG columns will be subset of needed columns.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 392)
<https://reviews.apache.org/r/37985/#comment153876>
Similarly as above. None of these methods gets the sarg column names instead it gets the included column names.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1388)
<https://reviews.apache.org/r/37985/#comment153882>
This is the actual internal column index corresponding to SARG columns. Rename suggestion again. mapSargColumnsToInternalColIdx()?
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1393)
<https://reviews.apache.org/r/37985/#comment153893>
where is this used? I don't see it being used anywhere. Can this be moved to relevant jira?
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java (line 1228)
<https://reviews.apache.org/r/37985/#comment153889>
indexInSourceTable will never be null. Right?
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java (line 1231)
<https://reviews.apache.org/r/37985/#comment153894>
Whats this translation doing exactly?
Is this trying to map between sarg column -> table column index -> orc internal column index?
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java (line 517)
<https://reviews.apache.org/r/37985/#comment153884>
Create a bug?
serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java (line 146)
<https://reviews.apache.org/r/37985/#comment153883>
I also don't understand why would it contain duplicates. IIRC, this was probably caused by multiple concatenation to the READ_COLUMN_IDS_CONF_STR. I am not sure if this happens anymore, in any case we should create a bug and remove this code. Or may be remove in the next patch. Also use, guava Splitter.splitToList?
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java (line 28)
<https://reviews.apache.org/r/37985/#comment153895>
I would prefer setting new name based on internal column names.
For example:
Schema from filedump: struct<_col0:tinyint,_col1:smallint>
Current SARG: leaf-0 = (EQUALS i1 100)
After this patch: leaf-0 = (EQUALS _col1 100)
If we can map to internal names, the it will be easy to map sarg column names to internal column index. i1 -> 1 (after ripping off _col)
- Prasanth_J
On Sept. 2, 2015, 1:06 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37985/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 1:06 a.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 05efc5f
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSerde.java 8beff4b
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java fcb3746
> ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ProjectionPusher.java 4480600
> ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java e034650
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java 2dc15f9
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b809a23
> serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java 10086c5
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java 0778935
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java d27ac16
>
> Diff: https://reviews.apache.org/r/37985/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 37985: HIVE-11705 refactor SARG stripe filtering
for ORC into a method
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Sept. 2, 2015, 2:35 a.m., Swarnim Kulkarni wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 1460
> > <https://reviews.apache.org/r/37985/diff/2/?file=1061874#file1061874line1460>
> >
> > Nit: Could use parameter substitution instead of concatenating it ourselves.
existing log line
> On Sept. 2, 2015, 2:35 a.m., Swarnim Kulkarni wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 1473
> > <https://reviews.apache.org/r/37985/diff/2/?file=1061874#file1061874line1473>
> >
> > Should we check if filterColumns is not empty to avoid a ArrayindexOutOfBounds
moved existing code
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37985/#review97385
-----------------------------------------------------------
On Sept. 2, 2015, 1:06 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37985/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 1:06 a.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 05efc5f
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSerde.java 8beff4b
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java fcb3746
> ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ProjectionPusher.java 4480600
> ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java e034650
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java 2dc15f9
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b809a23
> serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java 10086c5
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java 0778935
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java d27ac16
>
> Diff: https://reviews.apache.org/r/37985/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 37985: HIVE-11705 refactor SARG stripe filtering
for ORC into a method
Posted by Swarnim Kulkarni <ku...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37985/#review97385
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 288)
<https://reviews.apache.org/r/37985/#comment153268>
Any reason we are not doing this right away? The reason I ask is the sarg object might be huge and since INFO is the default log level, this probably would add considerable load to the hive logs correct?
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1414)
<https://reviews.apache.org/r/37985/#comment153272>
Nit: Could use parameter substitution instead of concatenating it ourselves.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1423)
<https://reviews.apache.org/r/37985/#comment153273>
Nit: Fix formatting.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1427)
<https://reviews.apache.org/r/37985/#comment153274>
Should we check if filterColumns is not empty to avoid a ArrayindexOutOfBounds
serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java (line 146)
<https://reviews.apache.org/r/37985/#comment153275>
Should we log a bug for this?
- Swarnim Kulkarni
On Sept. 2, 2015, 1:06 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37985/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 1:06 a.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 05efc5f
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSerde.java 8beff4b
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java fcb3746
> ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ProjectionPusher.java 4480600
> ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java e034650
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java 2dc15f9
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b809a23
> serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java 10086c5
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java 0778935
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java d27ac16
>
> Diff: https://reviews.apache.org/r/37985/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 37985: HIVE-11705 refactor SARG stripe filtering
for ORC into a method
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37985/
-----------------------------------------------------------
(Updated Sept. 15, 2015, 1:55 a.m.)
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java cf8694e
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSerde.java 8beff4b
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java fcb3746
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ProjectionPusher.java 4480600
ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java e034650
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java 2dc15f9
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 16957b6
serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java 10086c5
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java 0778935
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java d27ac16
Diff: https://reviews.apache.org/r/37985/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 37985: HIVE-11705 refactor SARG stripe filtering
for ORC into a method
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37985/#review98251
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 273)
<https://reviews.apache.org/r/37985/#comment154571>
Is this hbase-metastore branch patch or trunk patch? If its trunk then this change doesn't reflect the JIRA title.
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java (line 1397)
<https://reviews.apache.org/r/37985/#comment154577>
Same reasoning again. If trunk patch, please create a followup jira and include this change as it is not used anywhere and is not a related change.
- Prasanth_J
On Sept. 8, 2015, 11:09 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37985/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2015, 11:09 p.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java cf8694e
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSerde.java 8beff4b
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java fcb3746
> ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ProjectionPusher.java 4480600
> ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java e034650
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java 2dc15f9
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java f6052e3
> serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java 10086c5
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java 0778935
> storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java d27ac16
>
> Diff: https://reviews.apache.org/r/37985/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 37985: HIVE-11705 refactor SARG stripe filtering
for ORC into a method
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37985/
-----------------------------------------------------------
(Updated Sept. 8, 2015, 11:09 p.m.)
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java cf8694e
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSerde.java 8beff4b
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java fcb3746
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ProjectionPusher.java 4480600
ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java e034650
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java 2dc15f9
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java f6052e3
serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java 10086c5
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java 0778935
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java d27ac16
Diff: https://reviews.apache.org/r/37985/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 37985: HIVE-11705 refactor SARG stripe filtering
for ORC into a method
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37985/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 1:06 a.m.)
Review request for hive and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 05efc5f
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSerde.java 8beff4b
ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java fcb3746
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ProjectionPusher.java 4480600
ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java e034650
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java 2dc15f9
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b809a23
serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java 10086c5
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java 0778935
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java d27ac16
Diff: https://reviews.apache.org/r/37985/diff/
Testing
-------
Thanks,
Sergey Shelukhin