You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Ittay Dror (JIRA)" <ji...@apache.org> on 2008/08/13 14:38:46 UTC

[jira] Created: (BUILDR-131) allow metadata in artifact definition

allow metadata in artifact definition
-------------------------------------

                 Key: BUILDR-131
                 URL: https://issues.apache.org/jira/browse/BUILDR-131
             Project: Buildr
          Issue Type: Improvement
          Components: Dependency management
    Affects Versions: 1.3.2
            Reporter: Ittay Dror
         Attachments: artifact.patch

Buildr allows to define artifacts as string ('group:id:type:version'), but also as a hash. The benefit I can see in using a hash is that it allows adding keys that are used by plugins when appropriate (metadata). However, Buildr always verifies that a hash contains just the keys it knows, by using rake_check_options. I wish that this check will be removed. 

Attached a patch that does that

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-131) allow metadata in artifact definition

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622299#action_12622299 ] 

Assaf Arkin commented on BUILDR-131:
------------------------------------

Hash and String are just two different representations of the same thing:
http://incubator.apache.org/buildr/artifacts.html#specifying_artifacts

Hash exists because in many places it's more convenient to work with them, and eventually strings are broken up into their component parts, but the two representations are kept consistent, otherwise you lose information.  The API specifically allows to convert from one to the other and back.



> allow metadata in artifact definition
> -------------------------------------
>
>                 Key: BUILDR-131
>                 URL: https://issues.apache.org/jira/browse/BUILDR-131
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Dependency management
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.3
>
>         Attachments: artifact.patch
>
>
> Buildr allows to define artifacts as string ('group:id:type:version'), but also as a hash. The benefit I can see in using a hash is that it allows adding keys that are used by plugins when appropriate (metadata). However, Buildr always sanitizes the hash, so all metadata is lost

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-131) allow metadata in artifact definition

Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ittay Dror updated BUILDR-131:
------------------------------

    Attachment: artifact.patch

> allow metadata in artifact definition
> -------------------------------------
>
>                 Key: BUILDR-131
>                 URL: https://issues.apache.org/jira/browse/BUILDR-131
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Dependency management
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>         Attachments: artifact.patch
>
>
> Buildr allows to define artifacts as string ('group:id:type:version'), but also as a hash. The benefit I can see in using a hash is that it allows adding keys that are used by plugins when appropriate (metadata). However, Buildr always verifies that a hash contains just the keys it knows, by using rake_check_options. I wish that this check will be removed. 
> Attached a patch that does that

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-131) allow metadata in artifact definition

Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ittay Dror updated BUILDR-131:
------------------------------

    Attachment:     (was: artifact.patch)

> allow metadata in artifact definition
> -------------------------------------
>
>                 Key: BUILDR-131
>                 URL: https://issues.apache.org/jira/browse/BUILDR-131
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Dependency management
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.3
>
>
> Buildr allows to define artifacts as string ('group:id:type:version'), but also as a hash. The benefit I can see in using a hash is that it allows adding keys that are used by plugins when appropriate (metadata). However, Buildr always sanitizes the hash, so all metadata is lost

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-131) allow metadata in artifact definition

Posted by "Victor Hugo Borja (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622320#action_12622320 ] 

Victor Hugo Borja commented on BUILDR-131:
------------------------------------------

As I see it, artifacts are just a way of pointing to files in maven repositories, let's keep them simple.
So if you need to add metadata on artifacts, you could add it to the jar's manifest.

OSGi bundles are more advanced than maven artifacts in that they allow the user to add more information about the bundle, again those details are stored on the jar's manifest. OSGi support is planned for a future Buildr release.

> allow metadata in artifact definition
> -------------------------------------
>
>                 Key: BUILDR-131
>                 URL: https://issues.apache.org/jira/browse/BUILDR-131
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Dependency management
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.3
>
>
> Buildr allows to define artifacts as string ('group:id:type:version'), but also as a hash. The benefit I can see in using a hash is that it allows adding keys that are used by plugins when appropriate (metadata). However, Buildr always sanitizes the hash, so all metadata is lost

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-131) allow metadata in artifact definition

Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ittay Dror updated BUILDR-131:
------------------------------

    Description: 
Buildr allows to define artifacts as string ('group:id:type:version'), but also as a hash. The benefit I can see in using a hash is that it allows adding keys that are used by plugins when appropriate (metadata). However, Buildr always sanitizes the hash, so all metadata is lost



  was:
Buildr allows to define artifacts as string ('group:id:type:version'), but also as a hash. The benefit I can see in using a hash is that it allows adding keys that are used by plugins when appropriate (metadata). However, Buildr always verifies that a hash contains just the keys it knows, by using rake_check_options. I wish that this check will be removed. 

Attached a patch that does that


> allow metadata in artifact definition
> -------------------------------------
>
>                 Key: BUILDR-131
>                 URL: https://issues.apache.org/jira/browse/BUILDR-131
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Dependency management
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.3
>
>         Attachments: artifact.patch
>
>
> Buildr allows to define artifacts as string ('group:id:type:version'), but also as a hash. The benefit I can see in using a hash is that it allows adding keys that are used by plugins when appropriate (metadata). However, Buildr always sanitizes the hash, so all metadata is lost

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-131) allow metadata in artifact definition

Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622304#action_12622304 ] 

Ittay Dror commented on BUILDR-131:
-----------------------------------

The wish is for me to be able to specify metadata on an artifact. 

I was mentioning that using the hash form looked nice, but I'd take anything ;-)

> allow metadata in artifact definition
> -------------------------------------
>
>                 Key: BUILDR-131
>                 URL: https://issues.apache.org/jira/browse/BUILDR-131
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Dependency management
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.3
>
>
> Buildr allows to define artifacts as string ('group:id:type:version'), but also as a hash. The benefit I can see in using a hash is that it allows adding keys that are used by plugins when appropriate (metadata). However, Buildr always sanitizes the hash, so all metadata is lost

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-131) allow metadata in artifact definition

Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ittay Dror updated BUILDR-131:
------------------------------

    Fix Version/s: 1.3.3

> allow metadata in artifact definition
> -------------------------------------
>
>                 Key: BUILDR-131
>                 URL: https://issues.apache.org/jira/browse/BUILDR-131
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Dependency management
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.3
>
>         Attachments: artifact.patch
>
>
> Buildr allows to define artifacts as string ('group:id:type:version'), but also as a hash. The benefit I can see in using a hash is that it allows adding keys that are used by plugins when appropriate (metadata). However, Buildr always verifies that a hash contains just the keys it knows, by using rake_check_options. I wish that this check will be removed. 
> Attached a patch that does that

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (BUILDR-131) allow metadata in artifact definition

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Assaf Arkin resolved BUILDR-131.
--------------------------------

    Resolution: Won't Fix

Delegated to forthcoming dependency management.

> allow metadata in artifact definition
> -------------------------------------
>
>                 Key: BUILDR-131
>                 URL: https://issues.apache.org/jira/browse/BUILDR-131
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Dependency management
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.3
>
>
> Buildr allows to define artifacts as string ('group:id:type:version'), but also as a hash. The benefit I can see in using a hash is that it allows adding keys that are used by plugins when appropriate (metadata). However, Buildr always sanitizes the hash, so all metadata is lost

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.