You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2018/09/27 15:12:33 UTC

[GitHub] carbondata pull request #2768: [CARBONDATA-2594] Do not add InvertedIndex in...

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2768#discussion_r220964343
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java ---
    @@ -224,7 +224,7 @@ private ColumnSchema addColumn(StructField field, String parentName, AtomicInteg
             }
           }
         }
    -    if (newColumn.isDimensionColumn()) {
    +    if (newColumn.isDimensionColumn() && newColumn.isSortColumn()) {
    --- End diff --
    
    @jackylk In case of no sort , isSortColumn will be true for all the dimension columns. so above check is of no use.
    So I suggest to do like below.
    In case of no sort for each dimension column we have set isSortColumn to false  and keep your condition


---