You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/13 13:49:52 UTC

[GitHub] [flink] BenoitHanotte opened a new pull request #10843: [FLINK-15565][table-planner-blink] Remove deprecated logic in LogicalTypeDataTypeConverter.fromDataTypeToLogicalType

BenoitHanotte opened a new pull request #10843: [FLINK-15565][table-planner-blink] Remove deprecated logic in LogicalTypeDataTypeConverter.fromDataTypeToLogicalType
URL: https://github.com/apache/flink/pull/10843
 
 
   ## What is the purpose of the change
   
   It seems there exists 2 paths to do the conversion from DataType to LogicalType:
   
   1. TypeConversions.fromLegacyInfoToDataType():
   used for instance when calling TableSchema.fromTypeInformation().
   
   2. LogicalTypeDataTypeConverter.fromDataTypeToLogicalType():
   Deprecated but still used in TableSourceUtil and many other places.
   
   These 2 code paths can return a different LogicalType for the same input, leading to the planner throwing a ValidationException when the LogicalTypes are compared to ensure they are compatible.
   
   More info in https://issues.apache.org/jira/browse/FLINK-15574
   
   ## Brief change log
   
   - Removed the deprecated logic in LogicalTypeDataTypeConverter.fromDataTypeToLogicalType(), make it call directly TypeConversions.fromDataToLogicalType() instead.
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as DataType.getLogicalType() implementations (TypeConversions.fromDataToLogicalType() simply calls DataType.getLogicalType()).
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] BenoitHanotte closed pull request #10843: [FLINK-15574][table-planner-blink] Remove deprecated logic in LogicalTypeDataTypeConverter.fromDataTypeToLogicalType

Posted by GitBox <gi...@apache.org>.
BenoitHanotte closed pull request #10843: [FLINK-15574][table-planner-blink] Remove deprecated logic in LogicalTypeDataTypeConverter.fromDataTypeToLogicalType
URL: https://github.com/apache/flink/pull/10843
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10843: [FLINK-15574][table-planner-blink] Remove deprecated logic in LogicalTypeDataTypeConverter.fromDataTypeToLogicalType

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10843: [FLINK-15574][table-planner-blink] Remove deprecated logic in LogicalTypeDataTypeConverter.fromDataTypeToLogicalType
URL: https://github.com/apache/flink/pull/10843#issuecomment-573673896
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 3b02091b289dfeeab86a0dd52432d4b41f126dc7 (Mon Jan 13 13:54:58 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] BenoitHanotte commented on issue #10843: [FLINK-15574][table-planner-blink] Remove deprecated logic in LogicalTypeDataTypeConverter.fromDataTypeToLogicalType

Posted by GitBox <gi...@apache.org>.
BenoitHanotte commented on issue #10843: [FLINK-15574][table-planner-blink] Remove deprecated logic in LogicalTypeDataTypeConverter.fromDataTypeToLogicalType
URL: https://github.com/apache/flink/pull/10843#issuecomment-573752373
 
 
   Closing as it breaks other modules down the line... Back to the drawing board.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10843: [FLINK-15574][table-planner-blink] Remove deprecated logic in LogicalTypeDataTypeConverter.fromDataTypeToLogicalType

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10843: [FLINK-15574][table-planner-blink] Remove deprecated logic in LogicalTypeDataTypeConverter.fromDataTypeToLogicalType
URL: https://github.com/apache/flink/pull/10843#issuecomment-573702126
 
 
   <!--
   Meta data
   Hash:3b02091b289dfeeab86a0dd52432d4b41f126dc7 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:3b02091b289dfeeab86a0dd52432d4b41f126dc7
   -->
   ## CI report:
   
   * 3b02091b289dfeeab86a0dd52432d4b41f126dc7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10843: [FLINK-15574][table-planner-blink] Remove deprecated logic in LogicalTypeDataTypeConverter.fromDataTypeToLogicalType

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10843: [FLINK-15574][table-planner-blink] Remove deprecated logic in LogicalTypeDataTypeConverter.fromDataTypeToLogicalType
URL: https://github.com/apache/flink/pull/10843#issuecomment-573702126
 
 
   <!--
   Meta data
   Hash:3b02091b289dfeeab86a0dd52432d4b41f126dc7 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4297 TriggerType:PUSH TriggerID:3b02091b289dfeeab86a0dd52432d4b41f126dc7
   Hash:3b02091b289dfeeab86a0dd52432d4b41f126dc7 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144163857 TriggerType:PUSH TriggerID:3b02091b289dfeeab86a0dd52432d4b41f126dc7
   -->
   ## CI report:
   
   * 3b02091b289dfeeab86a0dd52432d4b41f126dc7 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144163857) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4297) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services