You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/02 04:30:42 UTC

[GitHub] [fineract] vorburger opened a new pull request #966: remove old constructor from SchedulerJobHelper (related to FINERACT-922)

vorburger opened a new pull request #966:
URL: https://github.com/apache/fineract/pull/966


   FINERACT-922


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] xurror commented on pull request #966: remove old constructor from SchedulerJobHelper (related to FINERACT-922)

Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #966:
URL: https://github.com/apache/fineract/pull/966#issuecomment-637892622


   @vorburger, there is some conflict here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #966: remove old constructor from SchedulerJobHelper (related to FINERACT-922)

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #966:
URL: https://github.com/apache/fineract/pull/966#issuecomment-637462007


   /rebase


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #966: remove old constructor from SchedulerJobHelper (related to FINERACT-922)

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #966:
URL: https://github.com/apache/fineract/pull/966#issuecomment-637748519


   @xurror if after you've merged #959 (do that one first, please) this has no conflicts, would you like to then merge this one as well? (If the merge of #959 causes conflicts on this one, then I'll fix them, later.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #966: remove old constructor from SchedulerJobHelper (related to FINERACT-922)

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #966:
URL: https://github.com/apache/fineract/pull/966#issuecomment-640203895


   This PR was much too big and contained a number of clean-up changes which should not be part of this. I've cleaned it up and dropped everything but the removal of the old constructor now. @xurror please merged whenever build passed - thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #966: remove old constructor from SchedulerJobHelper (related to FINERACT-922)

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #966:
URL: https://github.com/apache/fineract/pull/966#issuecomment-637293852


   This will have to be re-based after #968 for FINERACT-1016 for the build to pass.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] xurror merged pull request #966: remove old constructor from SchedulerJobHelper (related to FINERACT-922)

Posted by GitBox <gi...@apache.org>.
xurror merged pull request #966:
URL: https://github.com/apache/fineract/pull/966


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org