[GitHub] [inlong] dockerzhang commented on a diff in pull request #8085: [INLONG-8084][DataProxy] Add abnormal event statistics in sink

["dockerzhang (via GitHub)" <gi...@apache.org>]

dockerzhang commented on code in PR #8085:
URL: https://github.com/apache/inlong/pull/8085#discussion_r1204948921


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/CommonConfigHolder.java:
##########
@@ -75,6 +75,17 @@ public class CommonConfigHolder {
     // whether enable whitelist, optional field.
     public static final String KEY_ENABLE_WHITELIST = "proxy.enable.whitelist";
     public static final boolean VAL_DEF_ENABLE_WHITELIST = false;
+    // whether enable file metric, optional field.
+    public static final String KEY_ENABLE_FILEMETRIC = "filemetric.enable";

Review Comment:
   It's better to use `file.metric.enable' to make the configuration easy to understand.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org