[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1217: IGNITE-17806 Removed tx state on tx coordinator.

[GitBox <gi...@apache.org>]

sergeyuttsel commented on code in PR #1217:
URL: https://github.com/apache/ignite-3/pull/1217#discussion_r998111696


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java:
##########
@@ -330,7 +329,7 @@ public void checkTransactionsWithDml() throws Exception {
 
         var states = (Map<UUID, TxState>) IgniteTestUtils.getFieldValue(txManagerInternal, TxManagerImpl.class, "states");
 
-        states.forEach((k, v) -> assertNotSame(v, TxState.PENDING));
+        assertEquals(txManagerInternal.finished(), states.size());

Review Comment:
   I think it's not necessary. This is indirectly checked in `assertEquals(ROW_COUNT + 1 + 1 + 1 + 1 + 1, txManagerInternal.finished() - txPrevCnt);`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org