You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (Jira)" <ji...@apache.org> on 2020/06/03 08:26:00 UTC
[jira] [Commented] (OAK-9083) Remove unnecessary (un)boxing in
oak-store-document
[ https://issues.apache.org/jira/browse/OAK-9083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124748#comment-17124748 ]
Julian Reschke commented on OAK-9083:
-------------------------------------
I think this is a bad change.
First of all, it includes changes where the unboxing is not *removed*, but just made *implicit*. As such (and unless I'm missing something), it doesn't improve performance.
This leaves us with a *style* change. In the past, we left coding style to those developers who actually maintain the code. I personally prefer explicit unboxing, as it makes it clear what happens (for instance, when using implicit unboxing you might get NPEs in surprising places).
Finally, this has negative effects on:
1) the commit ("blame") history; for those lines changed here, it'll take one additional step to find out where that code originated from, and
2) mergeability: if we have to backport changes that are in or close to the modified lines, we'll get merge conflicts. These either need to be resolved manually (bad), or we'll have to backport this change as well (also bad, as it affects to many unrelated classes).
With that, I propose to backout the change, and to focus on the subset of changes that would actually affect performance.
cc [~mreutegg] [~larsgrefer]
> Remove unnecessary (un)boxing in oak-store-document
> ---------------------------------------------------
>
> Key: OAK-9083
> URL: https://issues.apache.org/jira/browse/OAK-9083
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Components: documentmk
> Reporter: Lars Grefer
> Assignee: Marcel Reutegger
> Priority: Major
> Fix For: 1.32.0
>
>
> The patch can be found here: https://github.com/apache/jackrabbit-oak/pull/227
--
This message was sent by Atlassian Jira
(v8.3.4#803005)