You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Bukama (via GitHub)" <gi...@apache.org> on 2025/03/16 19:12:10 UTC
[PR] Update articles about plugin execution configuration [maven-site]
Bukama opened a new pull request, #727:
URL: https://github.com/apache/maven-site/pull/727
This PR updates the articles about plugin configuration and lifecycle to
- make clear that Maven 4 breaks build when plugin is defined multiple times [MNGSITE-519]
- describe execution merge and inheritance more clear [MNGSITE-362]
- add Maven 4 execution priorities
- fix some formatting errors in the affected pages
The additions are all in this PR as they affect the same section of the configuration page.
Merge and inheritance behavior were verified with Maven 4.0.0-rc3 while updating the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update articles about plugin execution configuration [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama merged PR #727:
URL: https://github.com/apache/maven-site/pull/727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update articles about plugin execution configuration [maven-site]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #727:
URL: https://github.com/apache/maven-site/pull/727#discussion_r1999682924
##########
content/apt/guides/mini/guide-configuring-plugins.apt:
##########
@@ -54,7 +54,7 @@ Guide to Configuring Plug-ins
<<Important Note>>: Always define the version of each plugin to guarantee
build reproducibility. A good practice is to specify each build plugin's version in a <<<\<build\>\<pluginManagement/\>\</build\>>>>
- element. Often the \<pluginManagement/\> element is found in the parent POM.
+ element. Often the<<<<pluginManagement/\>>>> element is found in the parent POM.
Review Comment:
Missing space before `<<<<` ?
##########
content/apt/guides/mini/guide-configuring-plugins.apt:
##########
@@ -490,13 +490,16 @@ public class MyAnimalMojo
</project>
+----+
- The first execution with id "execution1" binds this configuration to the test phase. The second execution does not
+ The first execution with id <<<execution1>>> binds this configuration to the test phase. The second execution does not
have a <<<\<phase\>>>> tag, how do you think will this execution behave? Well, goals can have a default phase binding
as discussed further below. If the goal has a default phase binding then it will execute in that phase. But if the
goal is not bound to any lifecycle phase then it simply won't be executed during the build lifecycle.
Note that while execution id's have to be unique among all executions of a single plugin within a POM, they don't
- have to be unique across an inheritance hierarchy of POMs. Executions of the same id from different POMs are merged.
+ have to be unique across an inheritance hierarchy of POMs.
+ Executions with difference id's are merged, meaning they are all executed in the hierarchy order (parent first).
Review Comment:
`different`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update articles about plugin execution configuration [maven-site]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #727:
URL: https://github.com/apache/maven-site/pull/727#issuecomment-2730702933
@gnodet ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update articles about plugin execution configuration [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on PR #727:
URL: https://github.com/apache/maven-site/pull/727#issuecomment-2730699360
@cstamas Would you take a look at this please, we chatted about it some days ago - thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org