[GitHub] [doris] mrhhsg commented on a diff in pull request #21141: [performace](colddata) opt cold data read performance

["mrhhsg (via GitHub)" <gi...@apache.org>]

mrhhsg commented on code in PR #21141:
URL: https://github.com/apache/doris/pull/21141#discussion_r1241157243


##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -983,6 +983,22 @@ Status SegmentIterator::_init_return_column_iterators() {
                     new RowIdColumnIterator(_opts.tablet_id, _opts.rowset_id, _segment->id()));
             continue;
         }
+        std::set<ColumnId> del_cond_id_set;
+        _opts.delete_condition_predicates->get_all_column_ids(del_cond_id_set);
+        std::vector<bool> tmp_is_pred_column;
+        tmp_is_pred_column.resize(_schema->columns().size(), false);
+        if (!_col_predicates.empty() || !del_cond_id_set.empty()) {

Review Comment:
   没有必要判断 empty, 直接两个 for 遍历可能更好？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org