You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "anishshri-db (via GitHub)" <gi...@apache.org> on 2024/08/23 23:14:17 UTC

[PR] [SPARK-49372][SS] Ensure that latestSnapshot is set to none on close to avoid subsequent use [spark]

anishshri-db opened a new pull request, #47860:
URL: https://github.com/apache/spark/pull/47860

   ### What changes were proposed in this pull request?
   Ensure that latestSnapshot is set to none on close to avoid subsequent use
   
   
   ### Why are the changes needed?
   Changes are needed to ensure that latestSnapshot is not used after db close since it might throw an exception in the context of the maint thread
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Added unit tests
   
   Before the fix:
   ```
   [info] Run completed in 5 seconds, 666 milliseconds.
   [info] Total number of tests run: 8
   [info] Suites: completed 1, aborted 0
   [info] Tests: succeeded 6, failed 2, canceled 0, ignored 0, pending 0
   [info] *** 2 TESTS FAILED ***
   ```
   
   After the fix:
   ```
   [info] Run completed in 5 seconds, 661 milliseconds.
   [info] Total number of tests run: 8
   [info] Suites: completed 1, aborted 0
   [info] Tests: succeeded 8, failed 0, canceled 0, ignored 0, pending 0
   [info] All tests passed.
   ```
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-49372][SS] Ensure that latestSnapshot is set to none on close to avoid subsequent use [spark]

Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR closed pull request #47860: [SPARK-49372][SS] Ensure that latestSnapshot is set to none on close to avoid subsequent use
URL: https://github.com/apache/spark/pull/47860


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-49372][SS] Ensure that latestSnapshot is set to none on close to avoid subsequent use [spark]

Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on PR #47860:
URL: https://github.com/apache/spark/pull/47860#issuecomment-2307914700

   cc - @HeartSaVioR , @siying - PTAL, thx !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-49372][SS] Ensure that latestSnapshot is set to none on close to avoid subsequent use [spark]

Posted by "09306677806 (via GitHub)" <gi...@apache.org>.
09306677806 commented on PR #47860:
URL: https://github.com/apache/spark/pull/47860#issuecomment-2309145087

   0x7dB738F5c400f3734A9550aF79d0bF72339a6279


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-49372][SS] Ensure that latestSnapshot is set to none on close to avoid subsequent use [spark]

Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #47860:
URL: https://github.com/apache/spark/pull/47860#issuecomment-2309141887

   Thanks! Merging to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org