[GitHub] GabrielBrascher commented on a change in pull request #3007: Add missing ConfigDrive entries on existing zones after upgrade

[GitBox <gi...@apache.org>]

GabrielBrascher commented on a change in pull request #3007: Add missing ConfigDrive entries on existing zones after upgrade
URL: https://github.com/apache/cloudstack/pull/3007#discussion_r231122776
 
 

 ##########
 File path: server/src/com/cloud/network/NetworkServiceImpl.java
 ##########
 @@ -623,11 +624,42 @@ public boolean configure(final String name, final Map<String, Object> params) th
 
         _allowSubdomainNetworkAccess = Boolean.valueOf(_configs.get(Config.SubDomainNetworkAccess.key()));
 
+        verifyConfigDriveEntriesOnZones();
+
         s_logger.info("Network Service is configured.");
 
         return true;
     }
 
+    /**
+     * Verifies ConfigDrive entries on a zone. Adds Diabled ConfigDrive provider if missing
+     */
+    private void checkConfigDriveEntriesOnZone(DataCenterVO zone) {
 
 Review comment:
   What do you think of changing the name from `checkConfigDriveEntriesOnZone` to `addDisabledConfigDriveEntriesOnZone`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services