You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hairong Kuang (JIRA)" <ji...@apache.org> on 2008/09/03 01:03:44 UTC
[jira] Created: (HADOOP-4054) During edit log loading, an
underconstruction file's lease gets removed twice
During edit log loading, an underconstruction file's lease gets removed twice
-----------------------------------------------------------------------------
Key: HADOOP-4054
URL: https://issues.apache.org/jira/browse/HADOOP-4054
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Affects Versions: 0.19.0
Reporter: Hairong Kuang
Fix For: 0.19.0
The lease is removed on line 605: old = fsDir.unprotected(path, mtime);
It then gets removed again on line 637: fsNamesys.leaseManager.removeLease(cons.clientName, path);
The second removal results in an error message in the log, which is very annoying.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4054) During edit log loading, an
underconstruction file's lease gets removed twice
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628189#action_12628189 ]
Konstantin Shvachko commented on HADOOP-4054:
---------------------------------------------
This looks right.
But then you can also remove code that removes lease after {{unprotectedDelete()}} in line 673: in the OP_DELETE case.
And then variable {{old}} can be removed as it is not used.
> During edit log loading, an underconstruction file's lease gets removed twice
> -----------------------------------------------------------------------------
>
> Key: HADOOP-4054
> URL: https://issues.apache.org/jira/browse/HADOOP-4054
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.0
>
> Attachments: editLogLease.patch
>
>
> The lease is removed on line 605: old = fsDir.unprotected(path, mtime);
> It then gets removed again on line 637: fsNamesys.leaseManager.removeLease(cons.clientName, path);
> The second removal results in an error message in the log, which is very annoying.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4054) During edit log loading, an
underconstruction file's lease gets removed twice
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-4054:
----------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
> During edit log loading, an underconstruction file's lease gets removed twice
> -----------------------------------------------------------------------------
>
> Key: HADOOP-4054
> URL: https://issues.apache.org/jira/browse/HADOOP-4054
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.0
>
> Attachments: editLogLease.patch, editLogLease1.patch
>
>
> The lease is removed on line 605: old = fsDir.unprotected(path, mtime);
> It then gets removed again on line 637: fsNamesys.leaseManager.removeLease(cons.clientName, path);
> The second removal results in an error message in the log, which is very annoying.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4054) During edit log loading, an
underconstruction file's lease gets removed twice
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-4054:
----------------------------------
Attachment: editLogLease1.patch
Here is a patch that incorporates Konstantin's comments.
> During edit log loading, an underconstruction file's lease gets removed twice
> -----------------------------------------------------------------------------
>
> Key: HADOOP-4054
> URL: https://issues.apache.org/jira/browse/HADOOP-4054
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.0
>
> Attachments: editLogLease.patch, editLogLease1.patch
>
>
> The lease is removed on line 605: old = fsDir.unprotected(path, mtime);
> It then gets removed again on line 637: fsNamesys.leaseManager.removeLease(cons.clientName, path);
> The second removal results in an error message in the log, which is very annoying.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-4054) During edit log loading, an
underconstruction file's lease gets removed twice
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang reassigned HADOOP-4054:
-------------------------------------
Assignee: Hairong Kuang
> During edit log loading, an underconstruction file's lease gets removed twice
> -----------------------------------------------------------------------------
>
> Key: HADOOP-4054
> URL: https://issues.apache.org/jira/browse/HADOOP-4054
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.0
>
> Attachments: editLogLease.patch
>
>
> The lease is removed on line 605: old = fsDir.unprotected(path, mtime);
> It then gets removed again on line 637: fsNamesys.leaseManager.removeLease(cons.clientName, path);
> The second removal results in an error message in the log, which is very annoying.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4054) During edit log loading, an
underconstruction file's lease gets removed twice
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-4054:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
The failed unit tests are not related to this issue. The patch has been manual tested. I just committed this.
> During edit log loading, an underconstruction file's lease gets removed twice
> -----------------------------------------------------------------------------
>
> Key: HADOOP-4054
> URL: https://issues.apache.org/jira/browse/HADOOP-4054
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.0
>
> Attachments: editLogLease.patch, editLogLease1.patch
>
>
> The lease is removed on line 605: old = fsDir.unprotected(path, mtime);
> It then gets removed again on line 637: fsNamesys.leaseManager.removeLease(cons.clientName, path);
> The second removal results in an error message in the log, which is very annoying.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4054) During edit log loading, an
underconstruction file's lease gets removed twice
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629929#action_12629929 ]
Hadoop QA commented on HADOOP-4054:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12389471/editLogLease1.patch
against trunk revision 693705.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3234/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3234/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3234/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3234/console
This message is automatically generated.
> During edit log loading, an underconstruction file's lease gets removed twice
> -----------------------------------------------------------------------------
>
> Key: HADOOP-4054
> URL: https://issues.apache.org/jira/browse/HADOOP-4054
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.0
>
> Attachments: editLogLease.patch, editLogLease1.patch
>
>
> The lease is removed on line 605: old = fsDir.unprotected(path, mtime);
> It then gets removed again on line 637: fsNamesys.leaseManager.removeLease(cons.clientName, path);
> The second removal results in an error message in the log, which is very annoying.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4054) During edit log loading, an
underconstruction file's lease gets removed twice
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628228#action_12628228 ]
Konstantin Shvachko commented on HADOOP-4054:
---------------------------------------------
+1
> During edit log loading, an underconstruction file's lease gets removed twice
> -----------------------------------------------------------------------------
>
> Key: HADOOP-4054
> URL: https://issues.apache.org/jira/browse/HADOOP-4054
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.0
>
> Attachments: editLogLease.patch, editLogLease1.patch
>
>
> The lease is removed on line 605: old = fsDir.unprotected(path, mtime);
> It then gets removed again on line 637: fsNamesys.leaseManager.removeLease(cons.clientName, path);
> The second removal results in an error message in the log, which is very annoying.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4054) During edit log loading, an
underconstruction file's lease gets removed twice
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-4054:
----------------------------------
Attachment: editLogLease.patch
A patch for review.
> During edit log loading, an underconstruction file's lease gets removed twice
> -----------------------------------------------------------------------------
>
> Key: HADOOP-4054
> URL: https://issues.apache.org/jira/browse/HADOOP-4054
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Hairong Kuang
> Fix For: 0.19.0
>
> Attachments: editLogLease.patch
>
>
> The lease is removed on line 605: old = fsDir.unprotected(path, mtime);
> It then gets removed again on line 637: fsNamesys.leaseManager.removeLease(cons.clientName, path);
> The second removal results in an error message in the log, which is very annoying.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4054) During edit log loading, an
underconstruction file's lease gets removed twice
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-4054:
----------------------------------
Status: Patch Available (was: Open)
> During edit log loading, an underconstruction file's lease gets removed twice
> -----------------------------------------------------------------------------
>
> Key: HADOOP-4054
> URL: https://issues.apache.org/jira/browse/HADOOP-4054
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.0
>
> Attachments: editLogLease.patch
>
>
> The lease is removed on line 605: old = fsDir.unprotected(path, mtime);
> It then gets removed again on line 637: fsNamesys.leaseManager.removeLease(cons.clientName, path);
> The second removal results in an error message in the log, which is very annoying.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4054) During edit log loading, an
underconstruction file's lease gets removed twice
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-4054:
----------------------------------
Status: Open (was: Patch Available)
> During edit log loading, an underconstruction file's lease gets removed twice
> -----------------------------------------------------------------------------
>
> Key: HADOOP-4054
> URL: https://issues.apache.org/jira/browse/HADOOP-4054
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.19.0
>
> Attachments: editLogLease.patch, editLogLease1.patch
>
>
> The lease is removed on line 605: old = fsDir.unprotected(path, mtime);
> It then gets removed again on line 637: fsNamesys.leaseManager.removeLease(cons.clientName, path);
> The second removal results in an error message in the log, which is very annoying.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4054) During edit log loading, an
underconstruction file's lease gets removed twice
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627849#action_12627849 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4054:
------------------------------------------------
I think we don't need that second removal.
> During edit log loading, an underconstruction file's lease gets removed twice
> -----------------------------------------------------------------------------
>
> Key: HADOOP-4054
> URL: https://issues.apache.org/jira/browse/HADOOP-4054
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Hairong Kuang
> Fix For: 0.19.0
>
>
> The lease is removed on line 605: old = fsDir.unprotected(path, mtime);
> It then gets removed again on line 637: fsNamesys.leaseManager.removeLease(cons.clientName, path);
> The second removal results in an error message in the log, which is very annoying.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.