You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Shawn Heisey <so...@elyograg.org> on 2013/03/13 22:17:33 UTC

solr.core.name renamed to name?

The following two commits (one for trunk, one for 4.x) changed a bunch 
of properties.  I rely on the one named "solr.core.name" for my config, 
so when I upgraded from 4.2-SNAPSHOT to 4.3-SNAPSHOT, Solr wouldn't 
start my cores.

http://svn.apache.org/r1451797
http://svn.apache.org/r1454477

I don't mind that this changed, or that there was no notice - that is 
one of the hazards of running dev software.  I do however think that 
"name" is entirely too generic an identifier for a property, and that it 
should probably be at least "core.name" to avoid collisions.  Some of 
the other identifiers in the same object probably could also use prefixes.

Thanks,
Shawn

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: solr.core.name renamed to name?

Posted by Erick Erickson <er...@gmail.com>.
Hmmm, this is certainly stuff that I changed. The problem is that when we
make a properties file in a core (where you are already reading something
from the core directory), then it's equally silly to require that the
core.properties file contain
solr.core.name=mycollection
for instance.

See SOLR-4575, and oddly SOLR-4543 is a similar problem...

Short form is that I agree specifying system props as "name" isn't a good
idea, but I'm not quite sure the best way to fix it.....

Erick



On Wed, Mar 13, 2013 at 5:17 PM, Shawn Heisey <so...@elyograg.org> wrote:

> The following two commits (one for trunk, one for 4.x) changed a bunch of
> properties.  I rely on the one named "solr.core.name" for my config, so
> when I upgraded from 4.2-SNAPSHOT to 4.3-SNAPSHOT, Solr wouldn't start my
> cores.
>
> http://svn.apache.org/r1451797
> http://svn.apache.org/r1454477
>
> I don't mind that this changed, or that there was no notice - that is one
> of the hazards of running dev software.  I do however think that "name" is
> entirely too generic an identifier for a property, and that it should
> probably be at least "core.name" to avoid collisions.  Some of the other
> identifiers in the same object probably could also use prefixes.
>
> Thanks,
> Shawn
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.**org<de...@lucene.apache.org>
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>