You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/18 15:28:43 UTC

[GitHub] [arrow-datafusion] tustvold opened a new pull request, #2571: Fix avro tests (#2570)

tustvold opened a new pull request, #2571:
URL: https://github.com/apache/arrow-datafusion/pull/2571

   # Which issue does this PR close?
   
   Closes #2570
   
    # Rationale for this change
   
   See ticket
   
   # What changes are included in this PR?
   
   * Fix compilation of tests
   * Fix a mistake in avro -> arrow conversion that was being caught by the new arrow-rs validation logic :tada:
   * Adds avro feature to CI
   
   # Are there any user-facing changes?
   
   The previous logic was likely broken for lists
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #2571: Fix avro tests (#2570)

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2571:
URL: https://github.com/apache/arrow-datafusion/pull/2571#discussion_r876044559


##########
datafusion/core/src/avro_to_arrow/arrow_array_reader.rs:
##########
@@ -861,6 +861,7 @@ fn flatten_string_values(values: &[&Value]) -> Vec<Option<String>> {
     values
         .iter()
         .flat_map(|row| {
+            let row = maybe_resolve_union(row);

Review Comment:
   We must do this here, to match the logic used to deduce the offsets. Without this the offsets would not match the flattened values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] tustvold merged pull request #2571: Fix avro tests (#2570)

Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2571:
URL: https://github.com/apache/arrow-datafusion/pull/2571


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org