[GitHub] [beam] scwhittle commented on a diff in pull request #26085: Populate getWorkStream latencies in dataflow streaming worker harness

["scwhittle (via GitHub)" <gi...@apache.org>]

scwhittle commented on code in PR #26085:
URL: https://github.com/apache/beam/pull/26085#discussion_r1166036784


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -1133,7 +1147,14 @@ public Instant getStateStartTime() {
       return stateStartTime;
     }
 
-    public Iterable<Windmill.LatencyAttribution> getLatencyAttributionList() {
+    public void recordGetWorkStreamLatencies(List<LatencyAttribution> getWorkStreamLatencies) {

Review Comment:
   just take an iterable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org