[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24409: [SPARK-27513][BUILD] files in tarball should have uid/gid 0

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24409: [SPARK-27513][BUILD] files in tarball should have uid/gid 0
URL: https://github.com/apache/spark/pull/24409#discussion_r277024827
 
 

 ##########
 File path: dev/make-distribution.sh
 ##########
 @@ -286,6 +286,6 @@ if [ "$MAKE_TGZ" == "true" ]; then
   TARDIR="$SPARK_HOME/$TARDIR_NAME"
   rm -rf "$TARDIR"
   cp -r "$DISTDIR" "$TARDIR"
-  tar czf "spark-$VERSION-bin-$NAME.tgz" -C "$SPARK_HOME" "$TARDIR_NAME"
 
 Review comment:
   Ur, @koertkuipers . It seems that it's not robust enough. I'm using the latest `macOS Mojave 10.14.4`, but it fails by default. Although we are using `spark-rm` docker image, Mac is important dev environment and this failure is a regression.
   
   ```
   $ tar --version
   bsdtar 2.8.3 - libarchive 2.8.3
   
   $ tar czf "test.tgz" --numeric-owner --owner=0 "docs"
   tar: Option --owner=0 is not supported
   Usage:
     List:    tar -tf <archive-filename>
     Extract: tar -xf <archive-filename>
     Create:  tar -cf <archive-filename> [filenames...]
     Help:    tar --help
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org