[GitHub] [trafficserver] maskit commented on a diff in pull request #9482: Add interface for NetVC services

["maskit (via GitHub)" <gi...@apache.org>]

maskit commented on code in PR #9482:
URL: https://github.com/apache/trafficserver/pull/9482#discussion_r1128837887


##########
iocore/net/NetVConnection.cc:
##########
@@ -118,3 +118,19 @@ NetVCOptions::get_family_string() const
   }
   return {};
 }
+
+void *
+NetVConnection::get_service(const std::type_info &info)
+{
+  if (this->_services.find(std::type_index(info)) != this->_services.end()) {
+    return this;
+  } else {
+    return nullptr;
+  }
+}

Review Comment:
   Ok, looks like this approach doesn't work at a minimum. What about other approaches? Do you see any technical issues?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org