You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2005/07/21 04:37:57 UTC

[jira] Created: (MNG-626) mojos/plexus needs to work with setter based injection

mojos/plexus needs to work with setter based injection
------------------------------------------------------

         Key: MNG-626
         URL: http://jira.codehaus.org/browse/MNG-626
     Project: Maven 2
        Type: Task
  Components: maven-plugin-api  
 Reporter: Brett Porter
     Fix For: 2.0-beta-1


we've talked about putting setters on mojos for reusability - plexus needs to be able to actually use them (in the case where they do more than just assignment) instead of the private field injection.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MNG-626) mojos/plexus needs to work with setter based injection

Posted by "Kenney Westerhof (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-626?page=all ]
     
Kenney Westerhof closed MNG-626:
--------------------------------

    Resolution: Fixed

fixed in plexus svn revision 2402.

> mojos/plexus needs to work with setter based injection
> ------------------------------------------------------
>
>          Key: MNG-626
>          URL: http://jira.codehaus.org/browse/MNG-626
>      Project: Maven 2
>         Type: Task
>   Components: maven-plugin-api
>     Reporter: Brett Porter
>     Assignee: Kenney Westerhof
>      Fix For: 2.0-beta-1

>
>
> we've talked about putting setters on mojos for reusability - plexus needs to be able to actually use them (in the case where they do more than just assignment) instead of the private field injection.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Reopened: (MNG-626) mojos/plexus needs to work with setter based injection

Posted by "Kenney Westerhof (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-626?page=all ]
     
Kenney Westerhof reopened MNG-626:
----------------------------------


Unrolled commit - there seem to be more implications I wasn't aware of needing discussion.

> mojos/plexus needs to work with setter based injection
> ------------------------------------------------------
>
>          Key: MNG-626
>          URL: http://jira.codehaus.org/browse/MNG-626
>      Project: Maven 2
>         Type: Task
>   Components: maven-plugin-api
>     Reporter: Brett Porter
>     Assignee: Kenney Westerhof
>      Fix For: 2.0-beta-1

>
>
> we've talked about putting setters on mojos for reusability - plexus needs to be able to actually use them (in the case where they do more than just assignment) instead of the private field injection.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-626) mojos/plexus needs to work with setter based injection

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-626?page=comments#action_46068 ] 

Jason van Zyl commented on MNG-626:
-----------------------------------

Kenney, I rolled your changes back in, created an IT for the testing of a mojo using setters and I'm currently trying to fix the bootstrap.

> mojos/plexus needs to work with setter based injection
> ------------------------------------------------------
>
>          Key: MNG-626
>          URL: http://jira.codehaus.org/browse/MNG-626
>      Project: Maven 2
>         Type: Task
>   Components: maven-plugin-api
>     Reporter: Brett Porter
>     Assignee: Jason van Zyl
>     Priority: Blocker
>      Fix For: 2.0-beta-1

>
>
> we've talked about putting setters on mojos for reusability - plexus needs to be able to actually use them (in the case where they do more than just assignment) instead of the private field injection.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-626) mojos/plexus needs to work with setter based injection

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-626?page=all ]

Brett Porter updated MNG-626:
-----------------------------

    Priority: Blocker  (was: Critical)

> mojos/plexus needs to work with setter based injection
> ------------------------------------------------------
>
>          Key: MNG-626
>          URL: http://jira.codehaus.org/browse/MNG-626
>      Project: Maven 2
>         Type: Task
>   Components: maven-plugin-api
>     Reporter: Brett Porter
>     Priority: Blocker
>      Fix For: 2.0-beta-1

>
>
> we've talked about putting setters on mojos for reusability - plexus needs to be able to actually use them (in the case where they do more than just assignment) instead of the private field injection.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MNG-626) mojos/plexus needs to work with setter based injection

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-626?page=all ]
     
Jason van Zyl closed MNG-626:
-----------------------------

    Resolution: Fixed

Appears to be working as shown in it0064.

> mojos/plexus needs to work with setter based injection
> ------------------------------------------------------
>
>          Key: MNG-626
>          URL: http://jira.codehaus.org/browse/MNG-626
>      Project: Maven 2
>         Type: Task
>   Components: maven-plugin-api
>     Reporter: Brett Porter
>     Assignee: Jason van Zyl
>     Priority: Blocker
>      Fix For: 2.0-beta-1

>
>
> we've talked about putting setters on mojos for reusability - plexus needs to be able to actually use them (in the case where they do more than just assignment) instead of the private field injection.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-626) mojos/plexus needs to work with setter based injection

Posted by "Kenney Westerhof (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-626?page=comments#action_44514 ] 

Kenney Westerhof commented on MNG-626:
--------------------------------------

Using setters is finished, but I discovered that the ConsoleLogger has a private field 'String treshold'
and a method 'setThreshold(int)'. Configuration goes wrong since it tries the setter first, and the string "info"
cannot be parsed as a number. Still tackling this problem. Possibly try configuration for both types,
and use the first one that works.

> mojos/plexus needs to work with setter based injection
> ------------------------------------------------------
>
>          Key: MNG-626
>          URL: http://jira.codehaus.org/browse/MNG-626
>      Project: Maven 2
>         Type: Task
>   Components: maven-plugin-api
>     Reporter: Brett Porter
>     Assignee: Kenney Westerhof
>      Fix For: 2.0-beta-1

>
>
> we've talked about putting setters on mojos for reusability - plexus needs to be able to actually use them (in the case where they do more than just assignment) instead of the private field injection.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-626) mojos/plexus needs to work with setter based injection

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-626?page=comments#action_46069 ] 

Jason van Zyl commented on MNG-626:
-----------------------------------

Kenney, did you ever track down the setThreshold(int) problem? I just rolled in revision 2402 for the configurator code.

> mojos/plexus needs to work with setter based injection
> ------------------------------------------------------
>
>          Key: MNG-626
>          URL: http://jira.codehaus.org/browse/MNG-626
>      Project: Maven 2
>         Type: Task
>   Components: maven-plugin-api
>     Reporter: Brett Porter
>     Assignee: Jason van Zyl
>     Priority: Blocker
>      Fix For: 2.0-beta-1

>
>
> we've talked about putting setters on mojos for reusability - plexus needs to be able to actually use them (in the case where they do more than just assignment) instead of the private field injection.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-626) mojos/plexus needs to work with setter based injection

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-626?page=all ]

Brett Porter updated MNG-626:
-----------------------------

    Priority: Critical  (was: Major)

> mojos/plexus needs to work with setter based injection
> ------------------------------------------------------
>
>          Key: MNG-626
>          URL: http://jira.codehaus.org/browse/MNG-626
>      Project: Maven 2
>         Type: Task
>   Components: maven-plugin-api
>     Reporter: Brett Porter
>     Priority: Critical
>      Fix For: 2.0-beta-1

>
>
> we've talked about putting setters on mojos for reusability - plexus needs to be able to actually use them (in the case where they do more than just assignment) instead of the private field injection.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org