You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/25 08:54:12 UTC

[GitHub] tzulitai opened a new pull request #7818: [hotfix] [core] Clarify CompositeTypeSerializerSnapshot class signature

tzulitai opened a new pull request #7818: [hotfix] [core] Clarify CompositeTypeSerializerSnapshot class signature
URL: https://github.com/apache/flink/pull/7818
 
 
   ## What is the purpose of the change
   
   Prior to this PR, the class signature of `CompositeTypeSerializerSnapshot` allowed subclasses to have raw types, while also requiring subclasses to erase types and re-cast when providing the expected serializer class in constructors.
   
   This PR fixes the signature, as well as simplify subclass implementations of the class type erasure and re-casts.
   
   ## Brief change log
   
   - The main change is in the signature changes in the `CompositeTypeSerializerSnapshot` class.
   - Other changes in the subclasses corresponds to the signature change.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **yes**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **N/A**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services