You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@santuario.apache.org by co...@apache.org on 2017/02/13 11:52:47 UTC

svn commit: r1782755 - in /santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security: signature/XMLSignatureInputDebugger.java stax/impl/processor/input/AbstractSignatureReferenceVerifyInputProcessor.java

Author: coheigea
Date: Mon Feb 13 11:52:47 2017
New Revision: 1782755

URL: http://svn.apache.org/viewvc?rev=1782755&view=rev
Log:
Use isEmpty instead of size() compared to 0

Modified:
    santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/signature/XMLSignatureInputDebugger.java
    santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/stax/impl/processor/input/AbstractSignatureReferenceVerifyInputProcessor.java

Modified: santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/signature/XMLSignatureInputDebugger.java
URL: http://svn.apache.org/viewvc/santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/signature/XMLSignatureInputDebugger.java?rev=1782755&r1=1782754&r2=1782755&view=diff
==============================================================================
--- santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/signature/XMLSignatureInputDebugger.java (original)
+++ santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/signature/XMLSignatureInputDebugger.java Mon Feb 13 11:52:47 2017
@@ -141,7 +141,7 @@ public class XMLSignatureInputDebugger {
      * @throws XMLSignatureException
      */
     public String getHTMLRepresentation() throws XMLSignatureException {
-        if (this.xpathNodeSet == null || this.xpathNodeSet.size() == 0) {
+        if (this.xpathNodeSet == null || this.xpathNodeSet.isEmpty()) {
             return HTMLPrefix + "<blink>no node set, sorry</blink>" + HTMLSuffix;
         }
 

Modified: santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/stax/impl/processor/input/AbstractSignatureReferenceVerifyInputProcessor.java
URL: http://svn.apache.org/viewvc/santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/stax/impl/processor/input/AbstractSignatureReferenceVerifyInputProcessor.java?rev=1782755&r1=1782754&r2=1782755&view=diff
==============================================================================
--- santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/stax/impl/processor/input/AbstractSignatureReferenceVerifyInputProcessor.java (original)
+++ santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/stax/impl/processor/input/AbstractSignatureReferenceVerifyInputProcessor.java Mon Feb 13 11:52:47 2017
@@ -232,7 +232,7 @@ public abstract class AbstractSignatureR
             }
         }
 
-        if (externalReferences.size() > 0) {
+        if (!externalReferences.isEmpty()) {
             for (int i = 0; i < externalReferences.size(); i++) {
                 KeyValue<ResourceResolver, ReferenceType> keyValue = externalReferences.get(i);
                 verifyExternalReference(