You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/04 08:49:39 UTC

[GitHub] [rocketmq] ShannonDing commented on a diff in pull request #4775: [ISSUE #4776]Support tag in litepullconsumer assign mode

ShannonDing commented on code in PR #4775:
URL: https://github.com/apache/rocketmq/pull/4775#discussion_r937519054


##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java:
##########
@@ -531,6 +533,17 @@ public synchronized void assign(Collection<MessageQueue> messageQueues) {
         }
     }
 
+    public synchronized void setSubExpression4Assgin(final String topic, final String subExpression) {
+        if (subExpression == null || "".equals(subExpression)) {

Review Comment:
   StringUtils.isEmpty  is suggested.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org