You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by ndjensen <gi...@git.apache.org> on 2016/11/01 19:27:50 UTC
[GitHub] thrift pull request #1121: TTransport.py micro-optimization: don't call len(...
GitHub user ndjensen opened a pull request:
https://github.com/apache/thrift/pull/1121
TTransport.py micro-optimization: don't call len(chunk) twice
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ndjensen/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1121
----
commit bf990baf0cfbfa44ca0ee38df8fab1dccddb67e8
Author: Nate Jensen <na...@raytheon.com>
Date: 2016-11-01T19:18:23Z
micro-optimization: don't call len(chunk) twice
Change-Id: Idecfbe38ef7bfc2962cda8c8f4b8a487c8e51615
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1121: THRIFT-4007: TTransport.py micro-optimization: don't cal...
Posted by ndjensen <gi...@git.apache.org>.
Github user ndjensen commented on the issue:
https://github.com/apache/thrift/pull/1121
Sorry for the delay. https://issues.apache.org/jira/browse/THRIFT-4007
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1121: TTransport.py micro-optimization: don't call len(chunk) ...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1121
Ping @ndjensen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1121: TTransport.py micro-optimization: don't call len(chunk) ...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1121
Ping @ndjensen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1121: THRIFT-4007: TTransport.py micro-optimization: do...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1121: THRIFT-4007: TTransport.py micro-optimization: don't cal...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1121
Hello - please rebase on master and force push. I would like to see a CI build pass before merging; save perhaps job #17 which has been failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1121: TTransport.py micro-optimization: don't call len(chunk) ...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1121
Thanks!
Could you also create a JIRA ticket according to our [contrib guidelines](http://thrift.apache.org/docs/HowToContribute)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---