You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "shibd (via GitHub)" <gi...@apache.org> on 2023/06/20 10:07:12 UTC
[GitHub] [pulsar-client-cpp] shibd opened a new pull request, #287: Perfect missing tls related method definitions for C client.
shibd opened a new pull request, #287:
URL: https://github.com/apache/pulsar-client-cpp/pull/287
### Motivation
The current C for `tls_private_key_file_path` and `tls_certificate_file_path` param only defines the get and set method implementation, not the interface.
### Modifications
- Add get and set interface for `tls_private_key_file_path` and `tls_certificate_file_path`.
### Verifying this change
- Add `C_ClientConfigurationTest` to cover it.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] shibd commented on pull request #287: Add missing tls related method definitions for C client.
Posted by "shibd (via GitHub)" <gi...@apache.org>.
shibd commented on PR #287:
URL: https://github.com/apache/pulsar-client-cpp/pull/287#issuecomment-1600374951
> I see "Perfect" in the PR title, did you want to mean "Provide"?
Yes, these methods have implementations but no interfaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower merged pull request #287: Add missing tls related method definitions for C client.
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower merged PR #287:
URL: https://github.com/apache/pulsar-client-cpp/pull/287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-cpp] BewareMyPower commented on pull request #287: Perfect missing tls related method definitions for C client.
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on PR #287:
URL: https://github.com/apache/pulsar-client-cpp/pull/287#issuecomment-1600291310
I see "Perfect" in the PR title, did you want to mean "Provide"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org