You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/09/10 11:11:37 UTC

[PR] [Pipe] Stabilize IoTDBPipeAutoSplitIT for auto-dropped history pipe [iotdb]

Caideyipi opened a new pull request, #18621:
URL: https://github.com/apache/iotdb/pull/18621

   ## Description
   
   Fix the flaky IoTDBPipeAutoSplitIT assertion caused by a finite history-only pipe completing and being auto-dropped before SHOW PIPE.
   
   - Require the persistent non-full-sync pipes a2b1 and a2b3 to remain.
   - Allow a2b2 to be present or already auto-dropped, while rejecting unexpected or auto-split pipe names.
   - Use DROP PIPE IF EXISTS so cleanup succeeds in either lifecycle state.
   
   ## Verification
   
   - mvn spotless:apply -pl integration-test -P with-integration-tests
   - git diff --check
   - Target integration test could not complete locally because the configured Maven mirror returned HTTP 504 and the corresponding snapshot dependencies were unavailable offline.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added comments explaining the lifecycle race handled by the assertion.
   - [x] modified an existing integration test to cover the valid auto-drop state.
   
   <hr>
   
   ##### Key changed/added classes (or packages if there are too many classes) in this PR
   
   - IoTDBPipeAutoSplitIT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Pipe] Stabilize IoTDBPipeAutoSplitIT for auto-dropped history pipe [iotdb]

Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18621:
URL: https://github.com/apache/iotdb/pull/18621


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org