You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/02 12:41:42 UTC

[GitHub] [spark] HeartSaVioR commented on pull request #29729: [SPARK-32032][SS] Avoid infinite wait in driver because of KafkaConsumer.poll(long) API

HeartSaVioR commented on pull request #29729:
URL: https://github.com/apache/spark/pull/29729#issuecomment-702711824


   If I understand correctly, "in overall" (across driver and executors), it shouldn't change the requirement of permissions; there're three distinct operations described in the doc
   
   * On group resource read operation
   * On topic resource read operation
   * On topic resource describe operation
   
   and with and without this patch all three operations are used.
   
   That said, the behavior of `not checking group.id in executors` (https://github.com/apache/spark/pull/28623#issuecomment-633257746) is weird to me. Probably it's either Kafka bug or `on group resource read operation` doesn't leverage `group.id`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org