You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Justin Edelson <ju...@gmail.com> on 2010/03/22 17:05:16 UTC
Re: [jira] Commented: (SLING-1448) Sling-Initial-Content should be
able to load content into non-default workspace
I originally thought to do that, but it was problematic because of the need
to store the content loader pointer (or whatever you want to call the nodes
that go in /var/sling/bundle-content). Not impossible, but would have been a
more invasive change. I can take another look.
I also didn't think that one bundle loading to multiple workspaces was a
need. At least it isn't for me :)
Justin
On Mon, Mar 22, 2010 at 11:39 AM, Carsten Ziegeler <cz...@apache.org>wrote:
> What about using an attribute for the Sling-Initial-Content header
> instead of having an additional header? This would allow to install
> content into different workspaces from one bundle (not sure if someone
> really needs this though....however using attributes looks a little bit
> nicer to me....).
>
> So this would be something like
>
> SLING-INF/content/home;path:=/sites/sling_website;workspace:=xyz
>
> Regards
> Carsten
>
> Justin Edelson (JIRA) wrote
> >
> > [
> https://issues.apache.org/jira/browse/SLING-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847697#action_12847697]
> >
> > Justin Edelson commented on SLING-1448:
> > ---------------------------------------
> >
> > done in r925533 and documented at
> http://cwiki.apache.org/confluence/display/SLINGxSITE/Content+Loading+%28jcr.contentloader%29
> >
> >> Sling-Initial-Content should be able to load content into non-default
> workspace
> >>
> -------------------------------------------------------------------------------
> >>
> >> Key: SLING-1448
> >> URL: https://issues.apache.org/jira/browse/SLING-1448
> >> Project: Sling
> >> Issue Type: Improvement
> >> Components: JCR
> >> Reporter: Justin Edelson
> >> Assignee: Justin Edelson
> >> Fix For: JCR ContentLoader 2.0.8
> >>
> >>
> >
> >
>
>
> --
> Carsten Ziegeler
> cziegeler@apache.org
>
Re: [jira] Commented: (SLING-1448) Sling-Initial-Content should be
able to load content into non-default workspace
Posted by Carsten Ziegeler <cz...@apache.org>.
Justin Edelson wrote
> Hmm. OK. I screwed this up then. I put the content loader pointer in the
> same workspace as the content. But I see the need of what you're describing
> re: uninstall.
>
> I'll take another crack at this.
>
Cool, thanks!
Carsten
> Thanks,
> Justin
>
>
>>
>>> I also didn't think that one bundle loading to multiple workspaces was a
>>> need. At least it isn't for me :)
>> Hehe :) Me neither...but I think that using attributes for this stuff is
>> nicer :)
>>
>> Carsten
>>
>>>
>>> Justin
>>>
>>>
>>> On Mon, Mar 22, 2010 at 11:39 AM, Carsten Ziegeler <cziegeler@apache.org
>>> wrote:
>>>
>>>> What about using an attribute for the Sling-Initial-Content header
>>>> instead of having an additional header? This would allow to install
>>>> content into different workspaces from one bundle (not sure if someone
>>>> really needs this though....however using attributes looks a little bit
>>>> nicer to me....).
>>>>
>>>> So this would be something like
>>>>
>>>> SLING-INF/content/home;path:=/sites/sling_website;workspace:=xyz
>>>>
>>>> Regards
>>>> Carsten
>>>>
>>>> Justin Edelson (JIRA) wrote
>>>>>
>>>>> [
>>>>
>> https://issues.apache.org/jira/browse/SLING-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847697#action_12847697
>> ]
>>>>>
>>>>> Justin Edelson commented on SLING-1448:
>>>>> ---------------------------------------
>>>>>
>>>>> done in r925533 and documented at
>>>>
>> http://cwiki.apache.org/confluence/display/SLINGxSITE/Content+Loading+%28jcr.contentloader%29
>>>>>
>>>>>> Sling-Initial-Content should be able to load content into non-default
>>>> workspace
>>>>>>
>>>>
>> -------------------------------------------------------------------------------
>>>>>>
>>>>>> Key: SLING-1448
>>>>>> URL: https://issues.apache.org/jira/browse/SLING-1448
>>>>>> Project: Sling
>>>>>> Issue Type: Improvement
>>>>>> Components: JCR
>>>>>> Reporter: Justin Edelson
>>>>>> Assignee: Justin Edelson
>>>>>> Fix For: JCR ContentLoader 2.0.8
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Carsten Ziegeler
>>>> cziegeler@apache.org
>>>>
>>>
>>
>>
>> --
>> Carsten Ziegeler
>> cziegeler@apache.org
>>
>
--
Carsten Ziegeler
cziegeler@apache.org
Re: [jira] Commented: (SLING-1448) Sling-Initial-Content should be
able to load content into non-default workspace
Posted by Justin Edelson <ju...@gmail.com>.
On Mon, Mar 22, 2010 at 12:23 PM, Carsten Ziegeler <cz...@apache.org>wrote:
> Justin Edelson wrote
> > I originally thought to do that, but it was problematic because of the
> need
> > to store the content loader pointer (or whatever you want to call the
> nodes
> > that go in /var/sling/bundle-content). Not impossible, but would have
> been a
> > more invasive change. I can take another look.
> Hmm, not sure where you exactly see the problem :)
I think the content loader pointer should always be stored in the
> default workspace - but instead of just storing the node paths of the
> nodes that have been created, the workspace where these nodes have been
> created should be added to this information for uninstalling.
> Then the uninstall process must pick up this info accordingly and remove
> the nodes correctly.
>
Hmm. OK. I screwed this up then. I put the content loader pointer in the
same workspace as the content. But I see the need of what you're describing
re: uninstall.
I'll take another crack at this.
Thanks,
Justin
>
> > I also didn't think that one bundle loading to multiple workspaces was a
> > need. At least it isn't for me :)
> Hehe :) Me neither...but I think that using attributes for this stuff is
> nicer :)
>
> Carsten
>
> >
> > Justin
> >
> >
> > On Mon, Mar 22, 2010 at 11:39 AM, Carsten Ziegeler <cziegeler@apache.org
> >wrote:
> >
> >> What about using an attribute for the Sling-Initial-Content header
> >> instead of having an additional header? This would allow to install
> >> content into different workspaces from one bundle (not sure if someone
> >> really needs this though....however using attributes looks a little bit
> >> nicer to me....).
> >>
> >> So this would be something like
> >>
> >> SLING-INF/content/home;path:=/sites/sling_website;workspace:=xyz
> >>
> >> Regards
> >> Carsten
> >>
> >> Justin Edelson (JIRA) wrote
> >>>
> >>> [
> >>
> https://issues.apache.org/jira/browse/SLING-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847697#action_12847697
> ]
> >>>
> >>> Justin Edelson commented on SLING-1448:
> >>> ---------------------------------------
> >>>
> >>> done in r925533 and documented at
> >>
> http://cwiki.apache.org/confluence/display/SLINGxSITE/Content+Loading+%28jcr.contentloader%29
> >>>
> >>>> Sling-Initial-Content should be able to load content into non-default
> >> workspace
> >>>>
> >>
> -------------------------------------------------------------------------------
> >>>>
> >>>> Key: SLING-1448
> >>>> URL: https://issues.apache.org/jira/browse/SLING-1448
> >>>> Project: Sling
> >>>> Issue Type: Improvement
> >>>> Components: JCR
> >>>> Reporter: Justin Edelson
> >>>> Assignee: Justin Edelson
> >>>> Fix For: JCR ContentLoader 2.0.8
> >>>>
> >>>>
> >>>
> >>>
> >>
> >>
> >> --
> >> Carsten Ziegeler
> >> cziegeler@apache.org
> >>
> >
>
>
> --
> Carsten Ziegeler
> cziegeler@apache.org
>
Re: [jira] Commented: (SLING-1448) Sling-Initial-Content should be
able to load content into non-default workspace
Posted by Carsten Ziegeler <cz...@apache.org>.
Justin Edelson wrote
> I originally thought to do that, but it was problematic because of the need
> to store the content loader pointer (or whatever you want to call the nodes
> that go in /var/sling/bundle-content). Not impossible, but would have been a
> more invasive change. I can take another look.
Hmm, not sure where you exactly see the problem :)
I think the content loader pointer should always be stored in the
default workspace - but instead of just storing the node paths of the
nodes that have been created, the workspace where these nodes have been
created should be added to this information for uninstalling.
Then the uninstall process must pick up this info accordingly and remove
the nodes correctly.
> I also didn't think that one bundle loading to multiple workspaces was a
> need. At least it isn't for me :)
Hehe :) Me neither...but I think that using attributes for this stuff is
nicer :)
Carsten
>
> Justin
>
>
> On Mon, Mar 22, 2010 at 11:39 AM, Carsten Ziegeler <cz...@apache.org>wrote:
>
>> What about using an attribute for the Sling-Initial-Content header
>> instead of having an additional header? This would allow to install
>> content into different workspaces from one bundle (not sure if someone
>> really needs this though....however using attributes looks a little bit
>> nicer to me....).
>>
>> So this would be something like
>>
>> SLING-INF/content/home;path:=/sites/sling_website;workspace:=xyz
>>
>> Regards
>> Carsten
>>
>> Justin Edelson (JIRA) wrote
>>>
>>> [
>> https://issues.apache.org/jira/browse/SLING-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847697#action_12847697]
>>>
>>> Justin Edelson commented on SLING-1448:
>>> ---------------------------------------
>>>
>>> done in r925533 and documented at
>> http://cwiki.apache.org/confluence/display/SLINGxSITE/Content+Loading+%28jcr.contentloader%29
>>>
>>>> Sling-Initial-Content should be able to load content into non-default
>> workspace
>>>>
>> -------------------------------------------------------------------------------
>>>>
>>>> Key: SLING-1448
>>>> URL: https://issues.apache.org/jira/browse/SLING-1448
>>>> Project: Sling
>>>> Issue Type: Improvement
>>>> Components: JCR
>>>> Reporter: Justin Edelson
>>>> Assignee: Justin Edelson
>>>> Fix For: JCR ContentLoader 2.0.8
>>>>
>>>>
>>>
>>>
>>
>>
>> --
>> Carsten Ziegeler
>> cziegeler@apache.org
>>
>
--
Carsten Ziegeler
cziegeler@apache.org