You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by bo...@apache.org on 2024/11/22 14:39:30 UTC
(impala) 03/04: IMPALA-13560: Fix test_admission_controller_with_quota_configs test.
This is an automated email from the ASF dual-hosted git repository.
boroknagyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 201e7becadf960caa76f1acd901dafc0989d27b7
Author: Andrew Sherman <as...@cloudera.com>
AuthorDate: Thu Nov 21 14:13:25 2024 -0800
IMPALA-13560: Fix test_admission_controller_with_quota_configs test.
The intention of test_admission_controller_with_quota_configs() is to
run a workload with a variety of outcomes in a pool that has Admission
Control User Quotas Configured. The idea was that the User Quotas
configuration would not affect the workload that is run by
run_admission_test(). The configuration for 'queueF' limits the number
of concurrent queries that can be run by any user to 30. In the test
there is only one user, and the number of queries that are run is 50,
so there is potential for the User Quotas configuration to affect the
operation of the test. Fix this by bumping the Quota limit to 50.
TESTING
I ran tests in a similar environment to that where failures were
observed. Without the fix I saw a failure, and with the fix there were
no failures. This isn't sufficient to prove this fix is all that is
needed, but the change is safe and isolated.
Change-Id: Ie2cc81a5b95d07154b73d32daf67617c79283ac8
Reviewed-on: http://gerrit.cloudera.org:8080/22096
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
fe/src/test/resources/fair-scheduler-test2.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fe/src/test/resources/fair-scheduler-test2.xml b/fe/src/test/resources/fair-scheduler-test2.xml
index 7033a3cb2..b63b6ffd9 100644
--- a/fe/src/test/resources/fair-scheduler-test2.xml
+++ b/fe/src/test/resources/fair-scheduler-test2.xml
@@ -45,7 +45,7 @@
<aclSubmitApps>* </aclSubmitApps>
<userQueryLimit>
<user>*</user>
- <totalCount>30</totalCount>
+ <totalCount>50</totalCount>
</userQueryLimit>
</queue>
<aclSubmitApps> </aclSubmitApps>