You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/10 11:09:40 UTC

[GitHub] [shardingsphere] RaigorJiang opened a new issue, #21468: [DistSQL] Add SQL parser test case for `AddShardingHintTableValueStatement`

RaigorJiang opened a new issue, #21468:
URL: https://github.com/apache/shardingsphere/issues/21468

   
   ### Background
   
   `ADD SHARDING HINT DATABASE_VALUE xx = yy` is a syntax in [DistSQL RAL](https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-proxy/distsql/syntax/ral/), when `ShardingSphereSQLParserEngine` receives this SQL text, it parses it as `AddShardingHintTableValueStatement`. Now we need to add a test case for this parsing process to assert that the parsing is correct.
   
   
   ### Aim
   
   Add SQL parser test case for `AddShardingHintTableValueStatement`.
   
   - Affected files:
   
     - SQLParserTestCases (**modify**)
   
     - test/parser/src/main/resources/case/ral/updatable.xml (**modify**)
   
     - test/parser/src/main/resources/sql/supported/ral/updatable.xml (**modify**)
   
     - test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/updatable/AddShardingHintTableValueStatementTestCase.java (**create**)
   
     - test/parser/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/updatable/AddShardingHintTableValueStatementAssert.java (**create**)
   
     - UpdatableRALStatementAssert (**modify**)
   
   
   - After all, execute `DistSQLParserParameterizedTest#assertDistSQL()` for validation
   
   ### Basic Qualifications
   
   - Java
   - Maven
   
   
   ### Example FYI
   
   - ImportDatabaseConfigurationStatement
   - ImportDatabaseConfigurationStatementTestCase
   - ImportDatabaseConfigurationStatementAssert
   - SQLParserTestCases
   - search for "import-database-config"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ankit-dub commented on issue #21468: [DistSQL] Add SQL parser test case for `AddShardingHintTableValueStatement`

Posted by GitBox <gi...@apache.org>.
ankit-dub commented on issue #21468:
URL: https://github.com/apache/shardingsphere/issues/21468#issuecomment-1296711687

   @RaigorJiang get access denied while pushing the changes
   
   fatal: Could not read from remote repository.
   Please make sure you have the correct access rights
   and the repository exists.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #21468: [DistSQL] Add SQL parser test case for `AddShardingHintTableValueStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21468:
URL: https://github.com/apache/shardingsphere/issues/21468#issuecomment-1297074571

   > @RaigorJiang getting access denied while pushing the changes
   > 
   > ```
   > fatal: Could not read from remote repository.
   > Please make sure you have the correct access rights
   > and the repository exists.
   > ```
   
   We can't push code to Apache's master, please submit via `Pull Request`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #21468: [DistSQL] Add SQL parser test case for `AddShardingHintTableValueStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21468:
URL: https://github.com/apache/shardingsphere/issues/21468#issuecomment-1297897014

   
   
   > @RaigorJiang created the PR with changes. Can you review and approve workflow?
   
   Merged, thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #21468: [DistSQL] Add SQL parser test case for `AddShardingHintTableValueStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21468:
URL: https://github.com/apache/shardingsphere/issues/21468#issuecomment-1296446429

   Hi @ankit-dub 
   Thanks for your feedback, would you like to participate in this task?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ankit-dub commented on issue #21468: [DistSQL] Add SQL parser test case for `AddShardingHintTableValueStatement`

Posted by GitBox <gi...@apache.org>.
ankit-dub commented on issue #21468:
URL: https://github.com/apache/shardingsphere/issues/21468#issuecomment-1296476432

   Yeah I will take up this task @RaigorJiang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ankit-dub commented on issue #21468: [DistSQL] Add SQL parser test case for `AddShardingHintTableValueStatement`

Posted by GitBox <gi...@apache.org>.
ankit-dub commented on issue #21468:
URL: https://github.com/apache/shardingsphere/issues/21468#issuecomment-1297232519

   @RaigorJiang created the PR with changes. Can you review?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang closed issue #21468: [DistSQL] Add SQL parser test case for `AddShardingHintTableValueStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang closed issue #21468: [DistSQL] Add SQL parser test case for `AddShardingHintTableValueStatement`
URL: https://github.com/apache/shardingsphere/issues/21468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #21468: [DistSQL] Add SQL parser test case for `AddShardingHintTableValueStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21468:
URL: https://github.com/apache/shardingsphere/issues/21468#issuecomment-1297896663

   Fixed by #21873.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #21468: [DistSQL] Add SQL parser test case for `AddShardingHintTableValueStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21468:
URL: https://github.com/apache/shardingsphere/issues/21468#issuecomment-1297075436

   @ankit-dub  Please refer to https://shardingsphere.apache.org/community/en/involved/contribute/contributor/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] ankit-dub commented on issue #21468: [DistSQL] Add SQL parser test case for `AddShardingHintTableValueStatement`

Posted by GitBox <gi...@apache.org>.
ankit-dub commented on issue #21468:
URL: https://github.com/apache/shardingsphere/issues/21468#issuecomment-1296320230

   HintRALStatementAssert can be created for all Hint SQL parsing test cases, RAL statement are extended by Update, Query and Hint.
   UpdatableRALStatementAssert assertIs function is not compatible with Hint statement


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #21468: [DistSQL] Add SQL parser test case for `AddShardingHintTableValueStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21468:
URL: https://github.com/apache/shardingsphere/issues/21468#issuecomment-1296598354

   @ankit-dub Welcome~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org