You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/14 16:00:50 UTC

[GitHub] [fineract] vorburger opened a new pull request #1055: Spotless (FINERACT-1006)

vorburger opened a new pull request #1055:
URL: https://github.com/apache/fineract/pull/1055


   This PR is #943 from thesmallstar@
   
   plus the automated bulk reformatting (which needs to be done by me to avoid merge conflicts)
   
   FINERACT-1006


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger merged pull request #1055: Spotless (FINERACT-1006)

Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1055:
URL: https://github.com/apache/fineract/pull/1055


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] thesmallstar commented on pull request #1055: Spotless (FINERACT-1006)

Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1055:
URL: https://github.com/apache/fineract/pull/1055#issuecomment-644519884


   @vorburger Don't you think it would be a little bit problematic to have ./setting/preferences out of git ignore? If a contributor changes his pref to what he likes, he might add that to the commit, or any small change for instance what he prefers.
   Will it not be a problem in this situation? Am I missing anything?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org