You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org> on 2023/02/23 19:21:39 UTC
[GitHub] [age] MuhammadTahaNaveed opened a new pull request, #710: Implement isEmpty() predicate function
MuhammadTahaNaveed opened a new pull request, #710:
URL: https://github.com/apache/age/pull/710
- Implemented isEmpty() predicate function to check if a List, map or string is
empty.
- Added regression tests for isEmpty() function.
- Fixed formatting of conditional statements in agtype.c i.e. added braces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani merged pull request #710: Implement isEmpty() predicate function
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani merged PR #710:
URL: https://github.com/apache/age/pull/710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #710: Implement isEmpty() predicate function
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #710:
URL: https://github.com/apache/age/pull/710#issuecomment-1444866375
@MuhammadTahaNaveed I understand the desire to clean up the formatting in the code. However, I feel this much change should probably be in its own separate PR. Especially, since it makes it hard to review the actual changes that this PR addresses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] MuhammadTahaNaveed commented on pull request #710: Implement isEmpty() predicate function
Posted by "MuhammadTahaNaveed (via GitHub)" <gi...@apache.org>.
MuhammadTahaNaveed commented on PR #710:
URL: https://github.com/apache/age/pull/710#issuecomment-1445064760
> @MuhammadTahaNaveed I understand the desire to clean up the formatting in the code. However, I feel this much change should probably be in its own separate PR. Especially, since it makes it hard to review the actual changes that this PR addresses.
Hi john, sorry for making it difficult for you to review. I dropped the commit with format changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org