You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/21 04:49:21 UTC
[GitHub] [dubbo-go] watermelo opened a new pull request #530: Add comments for common directory
watermelo opened a new pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
Add comments
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#issuecomment-631894490
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=h1) Report
> Merging [#530](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #530 +/- ##
===========================================
- Coverage 66.55% 66.54% -0.02%
===========================================
Files 184 184
Lines 9729 9723 -6
===========================================
- Hits 6475 6470 -5
- Misses 2613 2614 +1
+ Partials 641 639 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `52.38% <ø> (ø)` | |
| [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/configurator.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWd1cmF0b3IuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9ncmFjZWZ1bF9zaHV0ZG93bi5nbw==) | `0.00% <ø> (ø)` | |
| [common/extension/loadbalance.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9sb2FkYmFsYW5jZS5nbw==) | `0.00% <ø> (ø)` | |
| [common/extension/metadata\_report\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZXBvcnRfZmFjdG9yeS5nbw==) | `0.00% <ø> (ø)` | |
| [common/extension/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9wcm90b2NvbC5nbw==) | `0.00% <ø> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=footer). Last update [84b38fe...8822f2c](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#issuecomment-633036058
please resolve conflicts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#discussion_r429540812
##########
File path: common/config/environment.go
##########
@@ -90,17 +91,17 @@ func (env *Environment) Configuration() *list.List {
return cfgList
}
-// SetDynamicConfiguration ...
+// SetDynamicConfiguration is used to set value for dynamicConfiguration
Review comment:
SetDynamicConfiguration sets value for dynamicConfiguration
##########
File path: common/config/environment.go
##########
@@ -109,7 +110,7 @@ func newInmemoryConfiguration(p *sync.Map) *InmemoryConfiguration {
return &InmemoryConfiguration{store: p}
}
-// GetProperty ...
+// GetProperty is used the key to get value from InmemoryConfiguration instance
Review comment:
GetProperty gets value from InmemoryConfiguration instance by @key
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on a change in pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on a change in pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#discussion_r429037829
##########
File path: common/config/environment.go
##########
@@ -46,15 +46,15 @@ var (
once sync.Once
)
-// GetEnvInstance ...
+// GetEnvInstance get env instance by singleton
Review comment:
so, find should be finds, update should be updates and so no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#discussion_r428480183
##########
File path: common/config/environment.go
##########
@@ -46,15 +46,15 @@ var (
once sync.Once
)
-// GetEnvInstance ...
+// GetEnvInstance get env instance by singleton
Review comment:
get -> gets? and the following errors should be fixed too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#issuecomment-631894490
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=h1) Report
> Merging [#530](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d2eee543d4810f178c75d793461708daedb2e617&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #530 +/- ##
===========================================
- Coverage 66.56% 66.43% -0.14%
===========================================
Files 184 184
Lines 9706 9706
===========================================
- Hits 6461 6448 -13
- Misses 2604 2616 +12
- Partials 641 642 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `52.38% <ø> (ø)` | |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcmVhZGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/configurator.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWd1cmF0b3IuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9ncmFjZWZ1bF9zaHV0ZG93bi5nbw==) | `0.00% <ø> (ø)` | |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `66.66% <ø> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=footer). Last update [d2eee54...d0a770f](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#issuecomment-631894490
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=h1) Report
> Merging [#530](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `78.12%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #530 +/- ##
===========================================
+ Coverage 66.55% 66.60% +0.05%
===========================================
Files 184 184
Lines 9729 9723 -6
===========================================
+ Hits 6475 6476 +1
+ Misses 2613 2607 -6
+ Partials 641 640 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `52.38% <ø> (ø)` | |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcmVhZGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/configurator.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWd1cmF0b3IuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9ncmFjZWZ1bF9zaHV0ZG93bi5nbw==) | `0.00% <ø> (ø)` | |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `66.66% <ø> (ø)` | |
| ... and [26 more](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=footer). Last update [84b38fe...6489acf](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#issuecomment-631894490
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=h1) Report
> Merging [#530](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `78.12%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #530 +/- ##
===========================================
+ Coverage 66.55% 66.57% +0.02%
===========================================
Files 184 184
Lines 9729 9720 -9
===========================================
- Hits 6475 6471 -4
+ Misses 2613 2611 -2
+ Partials 641 638 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `52.38% <ø> (ø)` | |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcmVhZGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/configurator.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWd1cmF0b3IuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9ncmFjZWZ1bF9zaHV0ZG93bi5nbw==) | `0.00% <ø> (ø)` | |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `66.66% <ø> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=footer). Last update [84b38fe...6489acf](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] watermelo commented on a change in pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
watermelo commented on a change in pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#discussion_r429039369
##########
File path: common/config/environment.go
##########
@@ -46,15 +46,15 @@ var (
once sync.Once
)
-// GetEnvInstance ...
+// GetEnvInstance get env instance by singleton
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#issuecomment-631894490
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=h1) Report
> Merging [#530](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #530 +/- ##
===========================================
- Coverage 66.55% 66.54% -0.02%
===========================================
Files 184 184
Lines 9729 9723 -6
===========================================
- Hits 6475 6470 -5
- Misses 2613 2614 +1
+ Partials 641 639 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `52.38% <ø> (ø)` | |
| [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/configurator.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWd1cmF0b3IuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9ncmFjZWZ1bF9zaHV0ZG93bi5nbw==) | `0.00% <ø> (ø)` | |
| [common/extension/loadbalance.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9sb2FkYmFsYW5jZS5nbw==) | `0.00% <ø> (ø)` | |
| [common/extension/metadata\_report\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZXBvcnRfZmFjdG9yeS5nbw==) | `0.00% <ø> (ø)` | |
| [common/extension/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9wcm90b2NvbC5nbw==) | `0.00% <ø> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=footer). Last update [84b38fe...2ffbe96](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx merged pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
zouyx merged pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#discussion_r429624625
##########
File path: common/extension/config_reader.go
##########
@@ -26,25 +26,25 @@ var (
defaults = make(map[string]string)
)
-// SetConfigReaders set a creator of config reader.
+// SetConfigReaders sets a creator of config reader with @name
func SetConfigReaders(name string, v func() interfaces.ConfigReader) {
configReaders[name] = v
}
-// GetConfigReaders get a config reader by name.
+// GetConfigReaders gets a config reader with @name
func GetConfigReaders(name string) interfaces.ConfigReader {
if configReaders[name] == nil {
panic("config reader for " + name + " is not existing, make sure you have imported the package.")
}
return configReaders[name]()
}
-// SetDefaultConfigReader set {name} to default config reader for {module}
+// SetDefaultConfigReader sets {name} to default config reader for {module}
Review comment:
what's the different `{name}` and `@name` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#issuecomment-631894490
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=h1) Report
> Merging [#530](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d2eee543d4810f178c75d793461708daedb2e617&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #530 +/- ##
===========================================
- Coverage 66.56% 66.43% -0.14%
===========================================
Files 184 184
Lines 9706 9706
===========================================
- Hits 6461 6448 -13
- Misses 2604 2616 +12
- Partials 641 642 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `52.38% <ø> (ø)` | |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcmVhZGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/configurator.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWd1cmF0b3IuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9ncmFjZWZ1bF9zaHV0ZG93bi5nbw==) | `0.00% <ø> (ø)` | |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `66.66% <ø> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=footer). Last update [d2eee54...9659d25](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#discussion_r429180038
##########
File path: common/config/environment.go
##########
@@ -67,21 +67,22 @@ func NewEnvInstance() {
// return env.configCenterFirst
//}
-// UpdateExternalConfigMap ...
+// UpdateExternalConfigMap update env externalConfigMap field
func (env *Environment) UpdateExternalConfigMap(externalMap map[string]string) {
for k, v := range externalMap {
env.externalConfigMap.Store(k, v)
}
}
-// UpdateAppExternalConfigMap ...
+// UpdateAppExternalConfigMap update env appExternalConfigMap field
func (env *Environment) UpdateAppExternalConfigMap(externalMap map[string]string) {
for k, v := range externalMap {
env.appExternalConfigMap.Store(k, v)
}
}
-// Configuration ...
+// List represents a doubly linked list.
+// Configuration put externalConfigMap and appExternalConfigMap into list
Review comment:
```suggestion
// Configuration puts externalConfigMap and appExternalConfigMap into list
// List represents a doubly linked list.
```
##########
File path: common/logger/logger.go
##########
@@ -125,18 +125,18 @@ func InitLogger(conf *zap.Config) {
getty.SetLogger(logger)
}
-// SetLogger ...
+// SetLogger sets logger for dubbo and getty
func SetLogger(log Logger) {
logger = log
getty.SetLogger(logger)
}
-// GetLogger ...
+// GetLogger gets the logger
func GetLogger() Logger {
return logger
}
-// SetLoggerLevel ...
+// SetLoggerLevel used to set logger level
Review comment:
use for?
##########
File path: common/extension/configurator.go
##########
@@ -61,7 +61,7 @@ func GetDefaultConfigurator(url *common.URL) config_center.Configurator {
}
-// GetDefaultConfiguratorFunc ...
+// GetDefaultConfiguratorFunc default configurator function
Review comment:
```suggestion
// GetDefaultConfiguratorFunc gets default configurator function
```
##########
File path: common/logger/logger.go
##########
@@ -145,13 +145,13 @@ func SetLoggerLevel(level string) bool {
return false
}
-// OpsLogger ...
+// OpsLogger used by the SetLoggerLevel
Review comment:
as above
##########
File path: common/url.go
##########
@@ -432,7 +434,7 @@ func (c URL) GetParamAndDecoded(key string) (string, error) {
return value, err
}
-// GetRawParam ...
+// GetRawParam is used to get raw param
Review comment:
use for?
##########
File path: common/url.go
##########
@@ -452,7 +454,7 @@ func (c URL) GetRawParam(key string) string {
}
}
-// GetParamBool ...
+// GetParamBool is used to judge whether key exists or not
Review comment:
use for?
##########
File path: common/node.go
##########
@@ -17,7 +17,7 @@
package common
-// Node ...
+// Node is used to process dubbo node
Review comment:
as above
##########
File path: common/logger/logger.go
##########
@@ -145,13 +145,13 @@ func SetLoggerLevel(level string) bool {
return false
}
-// OpsLogger ...
+// OpsLogger used by the SetLoggerLevel
type OpsLogger interface {
Logger
SetLoggerLevel(level string)
}
-// SetLoggerLevel ...
+// SetLoggerLevel used to set logger level
Review comment:
as above
##########
File path: common/url.go
##########
@@ -86,7 +86,7 @@ type baseUrl struct {
PrimitiveURL string
}
-// URL ...
+// URL is used to locate resourse to transfer data between nodes
Review comment:
use for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#issuecomment-631894490
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=h1) Report
> Merging [#530](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `78.12%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #530 +/- ##
===========================================
+ Coverage 66.55% 66.60% +0.05%
===========================================
Files 184 184
Lines 9729 9723 -6
===========================================
+ Hits 6475 6476 +1
+ Misses 2613 2607 -6
+ Partials 641 640 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `52.38% <ø> (ø)` | |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcmVhZGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/configurator.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWd1cmF0b3IuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9ncmFjZWZ1bF9zaHV0ZG93bi5nbw==) | `0.00% <ø> (ø)` | |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `66.66% <ø> (ø)` | |
| ... and [26 more](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=footer). Last update [84b38fe...2ffbe96](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #530: Add comments for common directory
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#issuecomment-631894490
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=h1) Report
> Merging [#530](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d2eee543d4810f178c75d793461708daedb2e617&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `78.12%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #530 +/- ##
========================================
Coverage 66.56% 66.57%
========================================
Files 184 184
Lines 9706 9720 +14
========================================
+ Hits 6461 6471 +10
- Misses 2604 2611 +7
+ Partials 641 638 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `52.38% <ø> (ø)` | |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcmVhZGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/configurator.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWd1cmF0b3IuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0.00% <ø> (ø)` | |
| [common/extension/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9ncmFjZWZ1bF9zaHV0ZG93bi5nbw==) | `0.00% <ø> (ø)` | |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `66.66% <ø> (ø)` | |
| ... and [27 more](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=footer). Last update [d2eee54...9659d25](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org