[GitHub] [beam] apilloud commented on a change in pull request #15915: [beam-12737] add API to handle failed rows in the collection due to sql query runtime error

[GitBox <gi...@apache.org>]

apilloud commented on a change in pull request #15915:
URL: https://github.com/apache/beam/pull/15915#discussion_r745129204



##########
File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java
##########
@@ -256,18 +283,25 @@ public void setup() {
     }
 
     @ProcessElement
-    public void processElement(@FieldAccess("row") Row row, OutputReceiver<Row> r) {
+    public void processElement(
+        @FieldAccess("row") Row row, OutputReceiver<Row> r, ProcessContext c) {

Review comment:
       Haven't done a full review yet. Using `ProcessContext` creates an implicit access to the raw input row, which breaks our ability to pushdown projects outside of SQL. (Tests are going in shortly with #15886.) You'll need to use `MultiOutputReceiver` instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org