You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/02/10 19:35:26 UTC

[GitHub] [bookkeeper] michaeljmarshall commented on a change in pull request #2597: Issue 2506: Skip unavailable bookies during verifyLedgerFragment

michaeljmarshall commented on a change in pull request #2597:
URL: https://github.com/apache/bookkeeper/pull/2597#discussion_r574018100



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/Auditor.java
##########
@@ -1197,6 +1197,8 @@ void checkAllLedgers() throws BKException, IOException, InterruptedException, Ke
 
             final CompletableFuture<Void> processFuture = new CompletableFuture<>();
 
+            Collection<BookieId> unavailableBookies = localAdmin.getUnavailableBookies();

Review comment:
       Thanks for the feedback. I hadn't realized this task was long running, and your suggestion makes sense. I'll take a look at updating this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org