[jira] [Commented] (TRAFODION-2554) JDBC T2 build changes needed for Trafodion release

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TRAFODION-2554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963262#comment-15963262 ] 

ASF GitHub Bot commented on TRAFODION-2554:
-------------------------------------------

Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1036#discussion_r110721219
  
    --- Diff: core/conn/jdbc_type2/src/main/java/org/apache/trafodion/jdbc/t2/SQLMXPooledConnectionManager.java ---
    @@ -23,14 +23,14 @@
      * Filename : SQLMXPooledConnectionManager.java
      */
     
    -package org.trafodion.jdbc.t2;
    +package org.apache.trafodion.jdbc.t2;
     
     import java.sql.*;
     import javax.sql.*;
     import java.util.Properties;
     import java.util.LinkedList;
     import java.io.PrintWriter;
    -import org.trafodion.jdbc.t2.*;
    +import org.apache.trafodion.jdbc.t2.*;
    --- End diff --
    
    Just a minor question: Do we really need to import the content of our own package?


> JDBC T2 build changes needed  for Trafodion release 
> ----------------------------------------------------
>
>                 Key: TRAFODION-2554
>                 URL: https://issues.apache.org/jira/browse/TRAFODION-2554
>             Project: Apache Trafodion
>          Issue Type: Task
>          Components: client-jdbc-t2
>    Affects Versions: 2.2-incubating
>            Reporter: Sandhya Sundaresan
>            Assignee: Alex Peng
>
> Need to convert T2 project to use Maven.
> Change POM.xml to be consistent with other POM files in Trafodion so we can publish the T2  jar file. 
> The group id needs to change to org.apache.trafodion.
> The NOTICE and LICENSE files need to be part of the JAR's META INF directory. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)