You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/15 05:57:23 UTC
[GitHub] [skywalking] yangyiweigege opened a new pull request, #9789: Fix alarm rule is not accurately
yangyiweigege opened a new pull request, #9789:
URL: https://github.com/apache/skywalking/pull/9789
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #9788.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9789: Fix alarm rule is not accurately
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9789:
URL: https://github.com/apache/skywalking/pull/9789#discussion_r996262604
##########
docs/en/changes/changes.md:
##########
@@ -61,6 +61,7 @@
regardless of the cluster's changes. However with this change SkyWalking can't react to the cluster changes in time, but the delay
is acceptable in our case.
* Optimize the query time of tasks in ProfileTaskCache.
+* Fix the windows in Alarm Rule hava wrong data,such as have same bucket metrics.
Review Comment:
```suggestion
* Fix metrics was put into wrong slot of the window in the alarting kernel.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #9789: Fix metrics was put into wrong slot of the window in the alarting kernel
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9789:
URL: https://github.com/apache/skywalking/pull/9789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #9789: Fix metrics was put into wrong slot of the window in the alarting kernel
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #9789:
URL: https://github.com/apache/skywalking/pull/9789#discussion_r996269608
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##########
@@ -222,7 +222,9 @@ private boolean validate(String target, List<String> includeList, List<String> e
* @param targetTime of moving target
*/
public void moveTo(LocalDateTime targetTime) {
- windows.values().forEach(window -> window.moveTo(targetTime));
+ //format targetTime to minute ,make sure the second is `00` and millisSeconds is `00` such as: 18:30:00.000
Review Comment:
```suggestion
// Truncate targetTime to minute, make sure the second is `00` and milliseconds is `00` such as: 18:30:00.000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] sonatype-lift[bot] commented on pull request #9789: Fix alarm rule is not accurately
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on PR #9789:
URL: https://github.com/apache/skywalking/pull/9789#issuecomment-1279675603
:warning: **6 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/skywalking/01GFD3FW1D4NTY83V94HG0Y16J?tab=technical-debt&utm_source=github.com&utm_campaign=lift-comment&utm_content=apache\%20skywalking) for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org