You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2018/02/01 17:56:18 UTC

[GitHub] carbondata pull request #1908: [CARBONDATA-2117]Fixed Syncronization issue i...

GitHub user kumarvishal09 opened a pull request:

    https://github.com/apache/carbondata/pull/1908

    [CARBONDATA-2117]Fixed Syncronization issue in Carbon ENV

    **Problem:** When creating multiple session (100) session initialisation is failing with below error
    
    java.lang.IllegalArgumentException: requirement failed: Config entry enable.unsafe.sort already registered!
    
    **Solution:** Currently in CarbonEnv we are updating global configuration(shared) and location configuration in class level synchronized block. In case of multiple session class level lock will not work , need to add global level lock so only one thread will update the global configuration 
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata master_ThreadIssueFIx

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1908.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1908
    
----
commit deb99eac720bdc39a2efba03e81649c8c504bf63
Author: kumarvishal <ku...@...>
Date:   2018-02-01T17:43:54Z

    Fixed thread issue

----


---

[GitHub] carbondata issue #1908: [CARBONDATA-2117]Fixed Syncronization issue in Carbo...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1908
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3292/



---

[GitHub] carbondata issue #1908: [CARBONDATA-2117]Fixed Syncronization issue in Carbo...

Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1908
  
    LGTM


---

[GitHub] carbondata issue #1908: [CARBONDATA-2117]Fixed Syncronization issue in Carbo...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1908
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2186/



---

[GitHub] carbondata pull request #1908: [CARBONDATA-2117]Fixed Syncronization issue i...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1908


---

[GitHub] carbondata issue #1908: [CARBONDATA-2117]Fixed Syncronization issue in Carbo...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1908
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3425/



---