You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/18 18:12:49 UTC

[GitHub] [incubator-nuttx] anchao opened a new pull request, #6470: wireless/bcm43xxx: add customized MAC address support

anchao opened a new pull request, #6470:
URL: https://github.com/apache/incubator-nuttx/pull/6470

   ## Summary
   
   wireless/bcm43xxx: add customized MAC address support
   
   ## Impact
   
   N/A
   
   ## Testing
   
   bcm43013 customized MAC address set


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6470: wireless/bcm43xxx: add customized MAC address support

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6470:
URL: https://github.com/apache/incubator-nuttx/pull/6470#discussion_r901002740


##########
boards/arm/stm32/photon/src/stm32_wlan.c:
##########
@@ -108,6 +108,15 @@ void bcmf_board_setup_oob_irq(int minor, int (*func)(void *), void *arg)
     }
 }
 
+/****************************************************************************
+ * Name: bcmf_board_etheraddr
+ ****************************************************************************/
+
+bool bcmf_board_etheraddr(FAR struct ether_addr *ethaddr)

Review Comment:
   ditto



##########
boards/arm/stm32/emw3162/src/stm32_wlan.c:
##########
@@ -126,6 +126,15 @@ void bcmf_board_setup_oob_irq(int minor, int (*func)(void *), void *arg)
     }
 }
 
+/****************************************************************************
+ * Name: bcmf_board_etheraddr
+ ****************************************************************************/
+
+bool bcmf_board_etheraddr(FAR struct ether_addr *ethaddr)

Review Comment:
   remove FAR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6470: wireless/bcm43xxx: add customized MAC address support

Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #6470:
URL: https://github.com/apache/incubator-nuttx/pull/6470#discussion_r901003170


##########
boards/arm/stm32/emw3162/src/stm32_wlan.c:
##########
@@ -126,6 +126,15 @@ void bcmf_board_setup_oob_irq(int minor, int (*func)(void *), void *arg)
     }
 }
 
+/****************************************************************************
+ * Name: bcmf_board_etheraddr
+ ****************************************************************************/
+
+bool bcmf_board_etheraddr(FAR struct ether_addr *ethaddr)

Review Comment:
   Done



##########
boards/arm/stm32/photon/src/stm32_wlan.c:
##########
@@ -108,6 +108,15 @@ void bcmf_board_setup_oob_irq(int minor, int (*func)(void *), void *arg)
     }
 }
 
+/****************************************************************************
+ * Name: bcmf_board_etheraddr
+ ****************************************************************************/
+
+bool bcmf_board_etheraddr(FAR struct ether_addr *ethaddr)

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6470: wireless/bcm43xxx: add customized MAC address support

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6470:
URL: https://github.com/apache/incubator-nuttx/pull/6470


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org