You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mi...@apache.org on 2016/11/25 06:00:37 UTC
zeppelin git commit: Clean unnecessary codes
Repository: zeppelin
Updated Branches:
refs/heads/master 978074449 -> bb01f9613
Clean unnecessary codes
### What is this PR for?
This PR is for cleaning unnecessary codes.
### What type of PR is it?
Refactoring
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: astroshim <hs...@nflabs.com>
Closes #1671 from astroshim/clean-codes and squashes the following commits:
52b9971 [astroshim] remove unnecessary codes
3b93adc [astroshim] clean unnecessary code
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/bb01f961
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/bb01f961
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/bb01f961
Branch: refs/heads/master
Commit: bb01f9613b125eea0ab894b3321f8482f83520cc
Parents: 9780744
Author: astroshim <hs...@nflabs.com>
Authored: Thu Nov 24 20:06:04 2016 +0900
Committer: Mina Lee <mi...@apache.org>
Committed: Fri Nov 25 15:00:31 2016 +0900
----------------------------------------------------------------------
.../zeppelin/interpreter/remote/RemoteInterpreterProcess.java | 7 -------
.../zeppelin/interpreter/remote/RemoteInterpreterServer.java | 1 -
2 files changed, 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/bb01f961/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterProcess.java
----------------------------------------------------------------------
diff --git a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterProcess.java b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterProcess.java
index c7b2205..c53d907 100644
--- a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterProcess.java
+++ b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterProcess.java
@@ -17,18 +17,14 @@
package org.apache.zeppelin.interpreter.remote;
import com.google.gson.Gson;
-import org.apache.commons.exec.*;
import org.apache.commons.pool2.impl.GenericObjectPool;
import org.apache.thrift.TException;
import org.apache.zeppelin.helium.ApplicationEventListener;
-import org.apache.zeppelin.interpreter.Constants;
-import org.apache.zeppelin.interpreter.InterpreterException;
import org.apache.zeppelin.interpreter.InterpreterGroup;
import org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService.Client;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import java.util.concurrent.atomic.AtomicInteger;
-import java.util.Properties;
/**
* Abstract class for interpreter process
@@ -36,14 +32,11 @@ import java.util.Properties;
public abstract class RemoteInterpreterProcess {
private static final Logger logger = LoggerFactory.getLogger(RemoteInterpreterProcess.class);
private final AtomicInteger referenceCount;
- private ExecuteWatchdog watchdog;
private GenericObjectPool<Client> clientPool;
private final RemoteInterpreterEventPoller remoteInterpreterEventPoller;
private final InterpreterContextRunnerPool interpreterContextRunnerPool;
private int connectTimeout;
- String host = "localhost";
- boolean isInterpreterAlreadyExecuting = false;
public RemoteInterpreterProcess(
int connectTimeout,
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/bb01f961/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
----------------------------------------------------------------------
diff --git a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
index b9b3868..4f5402c 100644
--- a/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
+++ b/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
@@ -69,7 +69,6 @@ public class RemoteInterpreterServer
Gson gson = new Gson();
RemoteInterpreterService.Processor<RemoteInterpreterServer> processor;
- RemoteInterpreterServer handler;
private int port;
private TThreadPoolServer server;