You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/02 14:14:38 UTC
[GitHub] [superset] stephenLYZ opened a new pull request, #19918: feat(plugin-chart-echarts): support horizontal bar chart
stephenLYZ opened a new pull request, #19918:
URL: https://github.com/apache/superset/pull/19918
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR supports horizontal bar chart for the new bar EChart. Here we switch these two bar orients (vertical and horizontal) by adding a `Bar Orient` control.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
#### Time series
##### Vertical
<img width="1525" alt="image" src="https://user-images.githubusercontent.com/11830681/166248100-2618b80b-8bb1-424c-8123-3483b01a48ca.png">
##### Horizontal
<img width="1527" alt="image" src="https://user-images.githubusercontent.com/11830681/166248149-4946388a-5051-4d13-a516-50a81e9b5be3.png">
#### Caterical
##### Vertical
<img width="1522" alt="image" src="https://user-images.githubusercontent.com/11830681/166248620-a69cd3e2-cd94-4850-9002-eace34802413.png">
#### Horizontal
<img width="1529" alt="image" src="https://user-images.githubusercontent.com/11830681/166248662-331544bc-9a02-4092-bfc5-74a5b294ebb4.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: https://github.com/apache/superset/issues/15543#issuecomment-1100962800
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1239354438
@Vicinius Yeah. You can see this PR supports both Time-series and Caterical bar chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1127700538
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1122161103
/testenv up FEATURE_GENERIC_CHART_AXES=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Hugh-Guan commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
Hugh-Guan commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1272702888
> > Will this also work without time-series? Just with the regular bar chart? I just want to do a horizontal bar chart without time column... I'm asking here because I don't have acess to the superset version or upgrading it right now, with Superset 2.0 will I be able to do this?
>
> I also wondered the same. I am trying to do it without time-series now
@Vicinius I saw your question, and I thought the same thing.
By the way, after superset was upgraded to TAG 2.0.0, did you implement horizontal function on your normal Bar Chart?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Hugh-Guan commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
Hugh-Guan commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1283367332
> Hey @Hugh-Guan and @Vicinius , I'm not sure if you've been following the "generic x-axis" development work recently, but the "Time-series line/bar/scatter" etc charts from the ECharts chart plugin nowadays support using any x-axis type if you enable the `GENERIC_CHART_AXES` feature flag. With that flag enabled, I believe the ECharts bar chart already has feature parity with the old NVD3 based bar chart, and will soon hopefully deprecate the old one. If you are able to test master branch, please give it a spin and see if it fits your use cases.
@villebro First of all, I am very sorry for taking so long to reply. Then, thank you very much for your advice and help.
The GENERIC_CHART_AXES feature solved my problem perfectly.
Also, I noticed that Metrics are sorted in the natural order, not the order of choice. So far I've prefixed Metrics to show them in the order I want them to. I don't know if there is a function to configure it accordingly.
Thanks again for your help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Chrisfufu commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
Chrisfufu commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1238875807
> Will this also work without time-series? Just with the regular bar chart? I just want to do a horizontal bar chart without time column... I'm asking here because I don't have acess to the superset version or upgrading it right now, with Superset 2.0 will I be able to do this?
I also wondered the same. I am trying to do it without time-series now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1123167299
@stephenLYZ Ephemeral environment spinning up at http://34.216.73.213:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Vicinius commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
Vicinius commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1242418968
@redwards101 were you able to sort the bars? that was a complaint on the comment that I pointed above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Vicinius commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
Vicinius commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1238524075
Will this also work without time-series? Just with the regular bar chart? I just want to do a horizontal bar chart without time column... I'm asking here because I don't have acess to the superset version or upgrading it right now, with Superset 2.0 will I be able to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] alldoami commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
alldoami commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1224880219
Looking through these comments... do I need to add a feature flag to my config to enable this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Hugh-Guan commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
Hugh-Guan commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1272246788
> @Vicinius是的。您可以看到此 PR 同时支持时间序列和餐饮条形图。
Excuse me, I have upgraded superset to tag 2.0.0 version, and the horizontal control option has appeared in Time-series Bar Chart. But Bar Chart does not have this control, do I need to do any additional configuration?
caption：Time-series Bar Chart
caption：Bar Chart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1123976242
@stephenLYZ Ephemeral environment spinning up at http://18.236.109.218:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #19918:
URL: https://github.com/apache/superset/pull/19918#discussion_r862893220
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx:
##########
@@ -87,6 +89,28 @@ const config: ControlPanelConfig = {
sections.advancedAnalyticsControls,
sections.annotationsAndLayersControls,
sections.forecastIntervalControls,
+ {
+ label: t('Chart Orient'),
Review Comment:
```suggestion
label: t('Chart orientation'),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
rusackas commented on code in PR #19918:
URL: https://github.com/apache/superset/pull/19918#discussion_r862893220
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx:
##########
@@ -87,6 +89,28 @@ const config: ControlPanelConfig = {
sections.advancedAnalyticsControls,
sections.annotationsAndLayersControls,
sections.forecastIntervalControls,
+ {
+ label: t('Chart Orient'),
Review Comment:
```suggestion
label: t('Chart Orientation'),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1116335655
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1116769707
I think there are two little problems that need to be addressed in this PR.
The small nitpicky one:
I think having a whole _section_ for Bar orientation is a bit much... it leads to having "Chart orientation" and "Bar orientation" right next to each other, which is redundant. I'm wondering if it makes more sense to move the "Bar orientation" control into the "Chart options" section, rather than creating a new section.
And the trickier one:
When you transpose the chart between row and column orientation, the other controls may now confuse people. We refer to some of the controls as "x axis" and "y axis" which is no longer the case. I think we need one of two possible solutions here:
• Update the terminology, like "Metric axis" and "Dimension axis" to be more specific
• Updating the labeling of the controls so that the X and Y labels update on the fly depending on chart orientation, and the controls remain "truthful"
Thoughts @stephenLYZ or @villebro ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1273654256
Hey @Hugh-Guan and @Vicinius , I'm not sure if you've been following the "generic x-axis" development work recently, but the "Time-series line/bar/scatter" etc charts from the ECharts chart plugin nowadays support using any x-axis type if you enable the `GENERIC_CHART_AXES` feature flag. With that flag enabled, I believe the ECharts bar chart already has feature parity with the old NVD3 based bar chart, and will soon hopefully deprecate the old one. If you are able to test master branch, please give it a spin and see if it fits your use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1122161410
@stephenLYZ Ephemeral environment creation is currently limited to committers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1127340164
> And the trickier one: When you transpose the chart between row and column orientation, the other controls may now confuse people. We refer to some of the controls as "x axis" and "y axis" which is no longer the case.
> I think we need one of two possible solutions here:
> • Update the terminology, like "Metric axis" and "Dimension axis" to be more specific
> • Updating the labeling of the controls so that the X and Y labels update on the fly depending on chart orientation, and the controls remain "truthful"
I totally agree, the label name of `x-axis` looks a bit misleading after it is rotated. The issue may not come from this PR, but from the current control panel design.
- the purpose of the `query panel` design is to describe the query fragment.
- the purpose of the `customize panel` design is to describe the properties of visualization.
The Bar chart transposition is a circumstance that a mixed query generator and viz definition.
1) In a vertical bar chart: the x-axis should be dimensions, it is represented by `x-axis` control and `dimension` control, y-axis should be metric(s).
2) In a horizontal bar chart: the x-axis should be metric(s). The `y-axis` should be dimensions, it is represented by x-axis control and dimension control.
Due to this confusing reason, lots of BI tools use `columns` and `rows` to represent `x-axis` and `y-axis` and provide many settings on each dimension/metric control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Vicinius commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
Vicinius commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1241122748
@redwards101 see if this helps you https://github.com/apache/superset/issues/5059#issuecomment-1238517310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1116305101
@rusackas Ephemeral environment spinning up at http://54.245.53.247:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
villebro commented on code in PR #19918:
URL: https://github.com/apache/superset/pull/19918#discussion_r864523160
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -318,57 +322,68 @@ export default function transformProps(
.map(entry => entry.name || '')
.concat(extractAnnotationLabels(annotationLayers, annotationData));
+ let xAxis: any = {
+ type: xAxisType,
+ name: xAxisTitle,
+ nameGap: convertInteger(xAxisTitleMargin),
+ nameLocation: 'middle',
+ axisLabel: {
+ hideOverlap: true,
+ formatter: xAxisFormatter,
+ rotate: xAxisLabelRotation,
+ },
+ minInterval:
+ xAxisType === 'time' && timeGrainSqla
+ ? TimeGrainToTimestamp[timeGrainSqla]
+ : 0,
+ };
+ let yAxis: any = {
+ ...defaultYAxis,
+ type: logAxis ? 'log' : 'value',
+ min,
+ max,
+ minorTick: { show: true },
+ minorSplitLine: { show: minorSplitLine },
+ axisLabel: { formatter },
+ scale: truncateYAxis,
+ name: yAxisTitle,
+ nameGap: convertInteger(yAxisTitleMargin),
+ nameLocation: yAxisTitlePosition === 'Left' ? 'middle' : 'end',
+ };
+
+ if (isHorizontal) {
+ const temp = xAxis;
+ xAxis = yAxis;
+ yAxis = temp;
+ }
+
const echartOptions: EChartsCoreOption = {
useUTC: true,
grid: {
...defaultGrid,
...padding,
},
- xAxis: {
- type: xAxisType,
- name: xAxisTitle,
- nameGap: convertInteger(xAxisTitleMargin),
- nameLocation: 'middle',
- axisLabel: {
- hideOverlap: true,
- formatter: xAxisFormatter,
- rotate: xAxisLabelRotation,
- },
- minInterval:
- xAxisType === 'time' && timeGrainSqla
- ? TimeGrainToTimestamp[timeGrainSqla]
- : 0,
- },
- yAxis: {
- ...defaultYAxis,
- type: logAxis ? 'log' : 'value',
- min,
- max,
- minorTick: { show: true },
- minorSplitLine: { show: minorSplitLine },
- axisLabel: { formatter },
- scale: truncateYAxis,
- name: yAxisTitle,
- nameGap: convertInteger(yAxisTitleMargin),
- nameLocation: yAxisTitlePosition === 'Left' ? 'middle' : 'end',
- },
+ xAxis,
+ yAxis,
tooltip: {
...defaultTooltip,
appendToBody: true,
trigger: richTooltip ? 'axis' : 'item',
formatter: (params: any) => {
+ const xIndex = isHorizontal ? 1 : 0;
+ const yIndex = isHorizontal ? 0 : 1;
Review Comment:
Slight simplification:
```suggestion
const [xIndex, yIndex] = isHorizontal ? [1, 0] : [0, 1];
```
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx:
##########
@@ -87,6 +89,28 @@ const config: ControlPanelConfig = {
sections.advancedAnalyticsControls,
sections.annotationsAndLayersControls,
sections.forecastIntervalControls,
+ {
+ label: t('Chart Orientation'),
+ expanded: true,
+ controlSetRows: [
+ [
+ {
+ name: 'bar_orient',
Review Comment:
could we call this `orientation`? I'm sure transposing will be relevant for other chart types as well, so I'm not sure we need to restrict this to the bar chart. I would also move this control to the `src/controls.tsx` file to make it readily available to other charts in this plugin.
```suggestion
name: 'orientation',
```
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -318,57 +322,68 @@ export default function transformProps(
.map(entry => entry.name || '')
.concat(extractAnnotationLabels(annotationLayers, annotationData));
+ let xAxis: any = {
+ type: xAxisType,
+ name: xAxisTitle,
+ nameGap: convertInteger(xAxisTitleMargin),
+ nameLocation: 'middle',
+ axisLabel: {
+ hideOverlap: true,
+ formatter: xAxisFormatter,
+ rotate: xAxisLabelRotation,
+ },
+ minInterval:
+ xAxisType === 'time' && timeGrainSqla
+ ? TimeGrainToTimestamp[timeGrainSqla]
+ : 0,
+ };
+ let yAxis: any = {
+ ...defaultYAxis,
+ type: logAxis ? 'log' : 'value',
+ min,
+ max,
+ minorTick: { show: true },
+ minorSplitLine: { show: minorSplitLine },
+ axisLabel: { formatter },
+ scale: truncateYAxis,
+ name: yAxisTitle,
+ nameGap: convertInteger(yAxisTitleMargin),
+ nameLocation: yAxisTitlePosition === 'Left' ? 'middle' : 'end',
+ };
+
+ if (isHorizontal) {
+ const temp = xAxis;
+ xAxis = yAxis;
+ yAxis = temp;
Review Comment:
nit: I believe you could also do this:
```suggestion
[xAxis, yAxis] = [yAxis, xAxis]
```
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/types.ts:
##########
@@ -38,6 +38,11 @@ export enum EchartsTimeseriesContributionType {
Column = 'column',
}
+export enum EchartsOrientType {
Review Comment:
nit: I think `OrientationType` could be a simpler name for this (no need to prefix with `Echarts` as that's implied)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1121297336
@stephenLYZ Ephemeral environment creation is currently limited to committers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] redwards101 commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
redwards101 commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1241326246
Ok, it's working now. I don't know why. I brought up the container again and suddenly I am now seeing the X-AXIS field that wasn't there before. The only notable recent difference is I decided to just set the DEFAULT_FEATURE_FLAGS in config.py and rebuild the image. I really can't see that as a reason, though. Maybe something was cached? Anyway, it's working great now.
Thanks for the feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1123970484
/testenv up FEATURE_GENERIC_CHART_AXES=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1127699039
@rusackas @zhaoyongjie That's a good input and currently it's based on the ability of the dynamic control to rotate - you can see that after setting the chart orientation, all x/y controls swap positions. Let's merge this one and improve this in the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ merged pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
stephenLYZ merged PR #19918:
URL: https://github.com/apache/superset/pull/19918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1117334539
@rusackas Yeah. That makes sense! The reason that I prefer to make a whole section for Bar orientation is I'd like to have all the following x/y control swaps (include "Chart Title" section). Maybe we can implement it by dynamic control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1116340066
@rusackas Ephemeral environment spinning up at http://18.236.159.61:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1121296959
/testenv up FEATURE_GENERIC_CHART_AXES=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1116773045
/testenv up FEATURE_GENERIC_CHART_AXES=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1119198594
# [Codecov](https://codecov.io/gh/apache/superset/pull/19918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19918](https://codecov.io/gh/apache/superset/pull/19918?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4a24bcb) into [master](https://codecov.io/gh/apache/superset/commit/481ccfe0a6e32caa58b760ca2d0bfb247a558f1f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (481ccfe) will **decrease** coverage by `0.01%`.
> The diff coverage is `38.46%`.
```diff
@@ Coverage Diff @@
## master #19918 +/- ##
==========================================
- Coverage 66.51% 66.49% -0.02%
==========================================
Files 1714 1715 +1
Lines 65027 65111 +84
Branches 6711 6753 +42
==========================================
+ Hits 43250 43297 +47
- Misses 20070 20098 +28
- Partials 1707 1716 +9
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.24% <38.46%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ugins/plugin-chart-echarts/src/Timeseries/types.ts](https://codecov.io/gh/apache/superset/pull/19918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90eXBlcy50cw==) | `100.00% <ø> (ø)` | |
| [...gin-chart-echarts/src/Timeseries/transformProps.ts](https://codecov.io/gh/apache/superset/pull/19918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1Qcm9wcy50cw==) | `56.86% <23.07%> (-1.04%)` | :arrow_down: |
| [...lugin-chart-echarts/src/Timeseries/transformers.ts](https://codecov.io/gh/apache/superset/pull/19918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1lcnMudHM=) | `50.40% <25.00%> (-0.84%)` | :arrow_down: |
| [...charts/src/Timeseries/Regular/Bar/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/19918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9SZWd1bGFyL0Jhci9jb250cm9sUGFuZWwudHN4) | `34.48% <32.00%> (-5.52%)` | :arrow_down: |
| [...plugins/plugin-chart-echarts/src/utils/forecast.ts](https://codecov.io/gh/apache/superset/pull/19918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvdXRpbHMvZm9yZWNhc3QudHM=) | `93.22% <50.00%> (-1.61%)` | :arrow_down: |
| [...d/plugins/plugin-chart-echarts/src/utils/series.ts](https://codecov.io/gh/apache/superset/pull/19918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvdXRpbHMvc2VyaWVzLnRz) | `92.00% <83.33%> (-0.96%)` | :arrow_down: |
| [...rset-ui-chart-controls/src/sections/chartTitle.tsx](https://codecov.io/gh/apache/superset/pull/19918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NlY3Rpb25zL2NoYXJ0VGl0bGUudHN4) | `100.00% <100.00%> (ø)` | |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/19918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-37.50%)` | :arrow_down: |
| [...tend/plugins/plugin-chart-handlebars/src/consts.ts](https://codecov.io/gh/apache/superset/pull/19918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtaGFuZGxlYmFycy9zcmMvY29uc3RzLnRz) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [superset-frontend/src/views/store.ts](https://codecov.io/gh/apache/superset/pull/19918/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3N0b3JlLnRz) | `80.00% <0.00%> (-10.00%)` | :arrow_down: |
| ... and [57 more](https://codecov.io/gh/apache/superset/pull/19918/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19918?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19918?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [481ccfe...4a24bcb](https://codecov.io/gh/apache/superset/pull/19918?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] redwards101 commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
redwards101 commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1242478669
> @redwards101 were you able to sort the bars? that was a complaint on the comment that I pointed above
No. Can't control the axis sorting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] redwards101 commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
redwards101 commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1241143415
> @redwards101 see if this helps you [#5059 (comment)](https://github.com/apache/superset/issues/5059#issuecomment-1238517310)
Thanks, but that's how I got here. There's clearly something I'm not doing right. Just don't know what it is yet. Looking for anyone who has it working in a docker environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1116775164
@rusackas Ephemeral environment spinning up at http://52.33.242.130:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1116303396
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1116913892
What my last comment didn't say is that this is AWESOME. Works great in `GENERIC_CHART_AXES` mode or the "normal" mode. I love that it even animates :D Pretty slick!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1115883518
I suspect this is one of the most anticipated PRs ever, love it! ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1123165082
/testenv up FEATURE_GENERIC_CHART_AXES=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] didia commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
didia commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1269353386
> @Vicinius Yeah. You can see this PR supports both Time-series and Caterical bar chart.
@stephenLYZ Thank you so much for this feature. I can see the feature for the new V2 time series but the "normal" bar doesn't give option to switch orientation. Also, I'm not seeing a "normal" bar chart v2 in the latest superset version. Am I missing something ?
No orientation option in existing bar chart
<img width="1144" alt="Screen Shot 2022-10-06 at 01 42 34" src="https://user-images.githubusercontent.com/3483656/194223672-472d563e-5d59-4c17-84e6-c5b9fa22f431.png">
No normal "V2" Bar chart
<img width="1066" alt="Screen Shot 2022-10-06 at 01 41 37" src="https://user-images.githubusercontent.com/3483656/194223451-6cee6597-e350-4290-9892-1ee488e56787.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] redwards101 commented on pull request #19918: feat(plugin-chart-echarts): support horizontal bar chart
Posted by GitBox <gi...@apache.org>.
redwards101 commented on PR #19918:
URL: https://github.com/apache/superset/pull/19918#issuecomment-1241075074
Maybe I'm dense (entirely possible), but I can't get it to work. I have the GENERIC_CHART_AXES feature set in superset_config.py. I'm using docker compose from near top of master, built the docker image to incorporate some other changes. Can't get the v2 bar to function any differently. What am I missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org