You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tubemq.apache.org by GitBox <gi...@apache.org> on 2021/03/28 13:08:20 UTC

[GitHub] [incubator-tubemq] gosonzhang opened a new pull request #449: [TUBEMQ-583] Adjust BrokerConfManager class implementation

gosonzhang opened a new pull request #449:
URL: https://github.com/apache/incubator-tubemq/pull/449


   1. Adjust the implementation logic of the BrokerConfManager class to meet the metadata operations based on the data classes under metastore.dao.entity(temporarily adjust it with the MetaDataManager class name)
   2. Adjust the metastore and include it under the metamanage module
   3. Adjust the method and business logic of the metadata class according to the implementation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] codecov-io commented on pull request #449: [TUBEMQ-583] Adjust BrokerConfManager class implementation

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #449:
URL: https://github.com/apache/incubator-tubemq/pull/449#issuecomment-808895192


   # [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/449?src=pr&el=h1) Report
   > Merging [#449](https://codecov.io/gh/apache/incubator-tubemq/pull/449?src=pr&el=desc) (af38361) into [TUBEMQ-570](https://codecov.io/gh/apache/incubator-tubemq/commit/36c9cdcd278bcc1a8b7ffe3b16f9524a323e814b?el=desc) (36c9cdc) will **decrease** coverage by `0.22%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-tubemq/pull/449/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2)](https://codecov.io/gh/apache/incubator-tubemq/pull/449?src=pr&el=tree)
   
   ```diff
   @@               Coverage Diff               @@
   ##             TUBEMQ-570    #449      +/-   ##
   ===============================================
   - Coverage          6.95%   6.73%   -0.23%     
   - Complexity          480     481       +1     
   ===============================================
     Files               291     294       +3     
     Lines             31885   32952    +1067     
     Branches           5178    5346     +168     
   ===============================================
   + Hits               2218    2219       +1     
   - Misses            29193   30260    +1067     
   + Partials            474     473       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-tubemq/pull/449?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../apache/tubemq/corebase/utils/KeyBuilderUtils.java](https://codecov.io/gh/apache/incubator-tubemq/pull/449/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS91dGlscy9LZXlCdWlsZGVyVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...e/tubemq/server/common/statusdef/ManageStatus.java](https://codecov.io/gh/apache/incubator-tubemq/pull/449/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vc3RhdHVzZGVmL01hbmFnZVN0YXR1cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ache/tubemq/server/common/utils/ProcessResult.java](https://codecov.io/gh/apache/incubator-tubemq/pull/449/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvUHJvY2Vzc1Jlc3VsdC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...server/master/bdbstore/DefaultBdbStoreService.java](https://codecov.io/gh/apache/incubator-tubemq/pull/449/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvYmRic3RvcmUvRGVmYXVsdEJkYlN0b3JlU2VydmljZS5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...aster/bdbstore/bdbentitys/BdbBlackGroupEntity.java](https://codecov.io/gh/apache/incubator-tubemq/pull/449/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvYmRic3RvcmUvYmRiZW50aXR5cy9CZGJCbGFja0dyb3VwRW50aXR5LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...aster/bdbstore/bdbentitys/BdbBrokerConfEntity.java](https://codecov.io/gh/apache/incubator-tubemq/pull/449/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvYmRic3RvcmUvYmRiZW50aXR5cy9CZGJCcm9rZXJDb25mRW50aXR5LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...r/bdbstore/bdbentitys/BdbClusterSettingEntity.java](https://codecov.io/gh/apache/incubator-tubemq/pull/449/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvYmRic3RvcmUvYmRiZW50aXR5cy9CZGJDbHVzdGVyU2V0dGluZ0VudGl0eS5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...store/bdbentitys/BdbConsumeGroupSettingEntity.java](https://codecov.io/gh/apache/incubator-tubemq/pull/449/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvYmRic3RvcmUvYmRiZW50aXR5cy9CZGJDb25zdW1lR3JvdXBTZXR0aW5nRW50aXR5LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../bdbstore/bdbentitys/BdbGroupFilterCondEntity.java](https://codecov.io/gh/apache/incubator-tubemq/pull/449/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvYmRic3RvcmUvYmRiZW50aXR5cy9CZGJHcm91cEZpbHRlckNvbmRFbnRpdHkuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...er/bdbstore/bdbentitys/BdbGroupFlowCtrlEntity.java](https://codecov.io/gh/apache/incubator-tubemq/pull/449/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvYmRic3RvcmUvYmRiZW50aXR5cy9CZGJHcm91cEZsb3dDdHJsRW50aXR5LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [33 more](https://codecov.io/gh/apache/incubator-tubemq/pull/449/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/449?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/449?src=pr&el=footer). Last update [36c9cdc...af38361](https://codecov.io/gh/apache/incubator-tubemq/pull/449?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tubemq] gosonzhang merged pull request #449: [TUBEMQ-583] Adjust BrokerConfManager class implementation

Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #449:
URL: https://github.com/apache/incubator-tubemq/pull/449


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org