You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by joseph-torres <gi...@git.apache.org> on 2017/12/18 22:03:03 UTC
[GitHub] spark pull request #20012: [SPARK-22824] Restore old offset for binary compa...
GitHub user joseph-torres opened a pull request:
https://github.com/apache/spark/pull/20012
[SPARK-22824] Restore old offset for binary compatibility
## What changes were proposed in this pull request?
Some users depend on source compatibility with the org.apache.spark.sql.execution.streaming.Offset class. Although this is not a stable interface, we can keep it in place for now to simplify upgrades to 2.3.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joseph-torres/spark binary-compat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20012.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20012
----
commit 7d1df9855dee8b6bce5ebed136b8da4275f178c7
Author: Jose Torres <jo...@databricks.com>
Date: 2017-12-18T21:34:50Z
Restore old offset for binary compatibility
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20012
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20012
**[Test build #85074 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85074/testReport)** for PR 20012 at commit [`7d1df98`](https://github.com/apache/spark/commit/7d1df9855dee8b6bce5ebed136b8da4275f178c7).
* This patch **fails RAT tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20012
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85088/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20012
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85074/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20012
**[Test build #85075 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85075/testReport)** for PR 20012 at commit [`c94699e`](https://github.com/apache/spark/commit/c94699e95e8013929bd03aeeb3505865ace96d75).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/20012
LGTM. Thanks! Merging to master!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20012
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85075/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20012
**[Test build #85076 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85076/testReport)** for PR 20012 at commit [`ace608d`](https://github.com/apache/spark/commit/ace608db502d10c89f0a65811bff1822f7a8e06c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20012
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85076/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20012
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20012
**[Test build #85076 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85076/testReport)** for PR 20012 at commit [`ace608d`](https://github.com/apache/spark/commit/ace608db502d10c89f0a65811bff1822f7a8e06c).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20012
**[Test build #85074 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85074/testReport)** for PR 20012 at commit [`7d1df98`](https://github.com/apache/spark/commit/7d1df9855dee8b6bce5ebed136b8da4275f178c7).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20012
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20012
**[Test build #85088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85088/testReport)** for PR 20012 at commit [`97fd2f9`](https://github.com/apache/spark/commit/97fd2f968d417bd7e690cf961efaac77bc2ef08d).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20012
**[Test build #85088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85088/testReport)** for PR 20012 at commit [`97fd2f9`](https://github.com/apache/spark/commit/97fd2f968d417bd7e690cf961efaac77bc2ef08d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20012: [SPARK-22824] Restore old offset for binary compa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20012
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20012
**[Test build #85075 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85075/testReport)** for PR 20012 at commit [`c94699e`](https://github.com/apache/spark/commit/c94699e95e8013929bd03aeeb3505865ace96d75).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20012: [SPARK-22824] Restore old offset for binary compatibilit...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20012
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org