You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Anton Luht (JIRA)" <ji...@apache.org> on 2006/12/11 13:31:26 UTC

[jira] Created: (HARMONY-2602) [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE

[classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE
---------------------------------------------------------------------------------------------

                 Key: HARMONY-2602
                 URL: http://issues.apache.org/jira/browse/HARMONY-2602
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Anton Luht
            Priority: Minor


javax.swing.plaf.basic.BasicTextAreaUI.create(null) throws NPE in RI but returns null in Harmony

Code to reproduce:

import javax.swing.*;
import javax.swing.plaf.basic.*;

public class Test {
        public static void main(String args[]) {
              System.out.println(new BasicTextAreaUI().create(null));
        }
}


Output in RI:
java version "1.5.0_06"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)

Exception in thread "main" java.lang.NullPointerException
        at javax.swing.plaf.basic.BasicTextAreaUI.create(Unknown Source)
        at Test.main(Test.java:6)

Output in Harmony:
Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
n or its licensors, as applicable.
java version "1.5.0"
pre-alpha : not complete or compatible
svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
http://incubator.apache.org/harmony
null

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2602) [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE

Posted by "Anton Luht (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2602?page=all ]

Anton Luht updated HARMONY-2602:
--------------------------------

    Patch Info: [Patch Available]

> [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2602
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2602
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>            Priority: Minor
>         Attachments: Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUITest.patch
>
>
> javax.swing.plaf.basic.BasicTextAreaUI.create(null) throws NPE in RI but returns null in Harmony
> Code to reproduce:
> import javax.swing.*;
> import javax.swing.plaf.basic.*;
> public class Test {
>         public static void main(String args[]) {
>               System.out.println(new BasicTextAreaUI().create(null));
>         }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> Exception in thread "main" java.lang.NullPointerException
>         at javax.swing.plaf.basic.BasicTextAreaUI.create(Unknown Source)
>         at Test.main(Test.java:6)
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> null

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HARMONY-2602) [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess resolved HARMONY-2602.
-----------------------------------

    Resolution: Fixed
      Assignee: Mark Hindess

Applied patches in r495954.  Please confirm they have been applied as expected.

> [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2602
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2602
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUITest.patch
>
>
> javax.swing.plaf.basic.BasicTextAreaUI.create(null) throws NPE in RI but returns null in Harmony
> Code to reproduce:
> import javax.swing.*;
> import javax.swing.plaf.basic.*;
> public class Test {
>         public static void main(String args[]) {
>               System.out.println(new BasicTextAreaUI().create(null));
>         }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> Exception in thread "main" java.lang.NullPointerException
>         at javax.swing.plaf.basic.BasicTextAreaUI.create(Unknown Source)
>         at Test.main(Test.java:6)
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> null

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2602) [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE

Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466965 ] 

Alexey A. Ivanov commented on HARMONY-2602:
-------------------------------------------

The fix can be simplified.
The code:
    if (element == null) {
            throw new NullPointerException();
    }
can be safely removed and the NPE will be naturally thrown because of the access to null object.

Mark, if you reopen the issue, I could provide the patch to fix it.

> [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2602
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2602
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUITest.patch
>
>
> javax.swing.plaf.basic.BasicTextAreaUI.create(null) throws NPE in RI but returns null in Harmony
> Code to reproduce:
> import javax.swing.*;
> import javax.swing.plaf.basic.*;
> public class Test {
>         public static void main(String args[]) {
>               System.out.println(new BasicTextAreaUI().create(null));
>         }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> Exception in thread "main" java.lang.NullPointerException
>         at javax.swing.plaf.basic.BasicTextAreaUI.create(Unknown Source)
>         at Test.main(Test.java:6)
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-2602) [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE

Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Petrenko closed HARMONY-2602.
------------------------------------

    Resolution: Fixed

Updated patch has been applied.
Please verify.

> [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2602
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2602
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>         Assigned To: Alexey Petrenko
>            Priority: Minor
>         Attachments: Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUITest.patch
>
>
> javax.swing.plaf.basic.BasicTextAreaUI.create(null) throws NPE in RI but returns null in Harmony
> Code to reproduce:
> import javax.swing.*;
> import javax.swing.plaf.basic.*;
> public class Test {
>         public static void main(String args[]) {
>               System.out.println(new BasicTextAreaUI().create(null));
>         }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> Exception in thread "main" java.lang.NullPointerException
>         at javax.swing.plaf.basic.BasicTextAreaUI.create(Unknown Source)
>         at Test.main(Test.java:6)
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HARMONY-2602) [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess reopened HARMONY-2602:
-----------------------------------


> [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2602
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2602
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUITest.patch
>
>
> javax.swing.plaf.basic.BasicTextAreaUI.create(null) throws NPE in RI but returns null in Harmony
> Code to reproduce:
> import javax.swing.*;
> import javax.swing.plaf.basic.*;
> public class Test {
>         public static void main(String args[]) {
>               System.out.println(new BasicTextAreaUI().create(null));
>         }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> Exception in thread "main" java.lang.NullPointerException
>         at javax.swing.plaf.basic.BasicTextAreaUI.create(Unknown Source)
>         at Test.main(Test.java:6)
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-2602) [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess reassigned HARMONY-2602:
-------------------------------------

    Assignee: Alexey Petrenko  (was: Mark Hindess)

> [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2602
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2602
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>         Assigned To: Alexey Petrenko
>            Priority: Minor
>         Attachments: Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUITest.patch
>
>
> javax.swing.plaf.basic.BasicTextAreaUI.create(null) throws NPE in RI but returns null in Harmony
> Code to reproduce:
> import javax.swing.*;
> import javax.swing.plaf.basic.*;
> public class Test {
>         public static void main(String args[]) {
>               System.out.println(new BasicTextAreaUI().create(null));
>         }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> Exception in thread "main" java.lang.NullPointerException
>         at javax.swing.plaf.basic.BasicTextAreaUI.create(Unknown Source)
>         at Test.main(Test.java:6)
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-2602) [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE

Posted by "sergey krivenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2602?page=all ]

sergey krivenko updated HARMONY-2602:
-------------------------------------

    Attachment: Harmony-2602-BasicTextAreaUITest.patch

the attached is a patch to the test

> [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2602
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2602
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>            Priority: Minor
>         Attachments: Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUITest.patch
>
>
> javax.swing.plaf.basic.BasicTextAreaUI.create(null) throws NPE in RI but returns null in Harmony
> Code to reproduce:
> import javax.swing.*;
> import javax.swing.plaf.basic.*;
> public class Test {
>         public static void main(String args[]) {
>               System.out.println(new BasicTextAreaUI().create(null));
>         }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> Exception in thread "main" java.lang.NullPointerException
>         at javax.swing.plaf.basic.BasicTextAreaUI.create(Unknown Source)
>         at Test.main(Test.java:6)
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> null

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2602) [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE

Posted by "sergey krivenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2602?page=all ]

sergey krivenko updated HARMONY-2602:
-------------------------------------

    Attachment: Harmony-2602-BasicTextAreaUI.patch

the attached is a fix to the bug

> [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2602
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2602
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>            Priority: Minor
>         Attachments: Harmony-2602-BasicTextAreaUI.patch
>
>
> javax.swing.plaf.basic.BasicTextAreaUI.create(null) throws NPE in RI but returns null in Harmony
> Code to reproduce:
> import javax.swing.*;
> import javax.swing.plaf.basic.*;
> public class Test {
>         public static void main(String args[]) {
>               System.out.println(new BasicTextAreaUI().create(null));
>         }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> Exception in thread "main" java.lang.NullPointerException
>         at javax.swing.plaf.basic.BasicTextAreaUI.create(Unknown Source)
>         at Test.main(Test.java:6)
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> null

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2602) [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE

Posted by "Sergey Krivenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464892 ] 

Sergey Krivenko commented on HARMONY-2602:
------------------------------------------

Verified

> [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2602
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2602
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUITest.patch
>
>
> javax.swing.plaf.basic.BasicTextAreaUI.create(null) throws NPE in RI but returns null in Harmony
> Code to reproduce:
> import javax.swing.*;
> import javax.swing.plaf.basic.*;
> public class Test {
>         public static void main(String args[]) {
>               System.out.println(new BasicTextAreaUI().create(null));
>         }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> Exception in thread "main" java.lang.NullPointerException
>         at javax.swing.plaf.basic.BasicTextAreaUI.create(Unknown Source)
>         at Test.main(Test.java:6)
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> null

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-2602) [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Hindess closed HARMONY-2602.
---------------------------------


Verified.  Thanks.

> [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2602
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2602
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUITest.patch
>
>
> javax.swing.plaf.basic.BasicTextAreaUI.create(null) throws NPE in RI but returns null in Harmony
> Code to reproduce:
> import javax.swing.*;
> import javax.swing.plaf.basic.*;
> public class Test {
>         public static void main(String args[]) {
>               System.out.println(new BasicTextAreaUI().create(null));
>         }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> Exception in thread "main" java.lang.NullPointerException
>         at javax.swing.plaf.basic.BasicTextAreaUI.create(Unknown Source)
>         at Test.main(Test.java:6)
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> null

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2602) [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE

Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470898 ] 

Alexey A. Ivanov commented on HARMONY-2602:
-------------------------------------------

That's fine.
Thank you Alexey.

> [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2602
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2602
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>         Assigned To: Alexey Petrenko
>            Priority: Minor
>         Attachments: Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUITest.patch
>
>
> javax.swing.plaf.basic.BasicTextAreaUI.create(null) throws NPE in RI but returns null in Harmony
> Code to reproduce:
> import javax.swing.*;
> import javax.swing.plaf.basic.*;
> public class Test {
>         public static void main(String args[]) {
>               System.out.println(new BasicTextAreaUI().create(null));
>         }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> Exception in thread "main" java.lang.NullPointerException
>         at javax.swing.plaf.basic.BasicTextAreaUI.create(Unknown Source)
>         at Test.main(Test.java:6)
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-2602) [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE

Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey A. Ivanov updated HARMONY-2602:
--------------------------------------

    Attachment: Harmony-2602-BasicTextAreaUI.patch

I've attached the updated fix which removes redundant check for null -- NPE will be thrown because of accessing element parameter if it's null.

> [classlib][swing][plaf] javax.swing.plaf.basic.BasicTextAreaUI.create(null) doesn't throw NPE
> ---------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2602
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2602
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Anton Luht
>         Assigned To: Mark Hindess
>            Priority: Minor
>         Attachments: Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUI.patch, Harmony-2602-BasicTextAreaUITest.patch
>
>
> javax.swing.plaf.basic.BasicTextAreaUI.create(null) throws NPE in RI but returns null in Harmony
> Code to reproduce:
> import javax.swing.*;
> import javax.swing.plaf.basic.*;
> public class Test {
>         public static void main(String args[]) {
>               System.out.println(new BasicTextAreaUI().create(null));
>         }
> }
> Output in RI:
> java version "1.5.0_06"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
> Java HotSpot(TM) Client VM (build 1.5.0_06-b05, mixed mode)
> Exception in thread "main" java.lang.NullPointerException
>         at javax.swing.plaf.basic.BasicTextAreaUI.create(Unknown Source)
>         at Test.main(Test.java:6)
> Output in Harmony:
> Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundatio
> n or its licensors, as applicable.
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r485537, (Dec 11 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> null

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.