You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2014/12/01 03:47:21 UTC
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/3521
[SPARK-4661][Core] Minor code and docs cleanup
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark SPARK-4661
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3521.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3521
----
commit 16f41cd4413064e6f58a30d49b64cbc93f11c3cb
Author: zsxwing <zs...@gmail.com>
Date: 2014-12-01T02:34:37Z
Minor code and docs cleanup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65014918
[Test build #23967 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23967/consoleFull) for PR 3521 at commit [`16f41cd`](https://github.com/apache/spark/commit/16f41cd4413064e6f58a30d49b64cbc93f11c3cb).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3521
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65017943
[Test build #537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/537/consoleFull) for PR 3521 at commit [`16f41cd`](https://github.com/apache/spark/commit/16f41cd4413064e6f58a30d49b64cbc93f11c3cb).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` trait ConnectionFactory extends Serializable `
* `class MatrixFactorizationModel(`
* `class CompressedSerializer(FramedSerializer):`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65018193
> That's a really weird test failure. I think that some other PR must have broken the build; I'll investigate.
My mistake. I thought casting to `SomeCustomClass[]` is unnecessary and removed it. But it's necessary because the compiler cannot infer the type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65018091
```
[warn] 6 warnings found
[error] /home/jenkins/workspace/NewSparkPullRequestBuilder/core/src/test/java/org/apache/spark/JavaAPISuite.java:1384: error: incompatible types
[error] SomeCustomClass[] collected = rdd.rdd().retag(SomeCustomClass.class).collect();
[error] ^
[error] required: SomeCustomClass[]
[error] found: Object
[error] Note: /home/jenkins/workspace/NewSparkPullRequestBuilder/core/src/test/java/org/apache/spark/JavaAPISuite.java uses or overrides a deprecated API.
[error] Note: Recompile with -Xlint:deprecation for details.
[error] 1 error
```
That's a really weird test failure. I think that some other PR must have broken the build; I'll investigate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65018197
[Test build #23969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23969/consoleFull) for PR 3521 at commit [`03cbe3f`](https://github.com/apache/spark/commit/03cbe3fd2797efa9db04c7e46e1d567dd2d32318).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65040116
> but the cast should also have a @SuppressWarnings("unchecked"), ideally, to avoid another warnings. I have some things like this taken care of in another open PR:
@srowen, yes. Then it's better to add it in your PR :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65018176
Actually, nevermind; looks like that was caused by this PR's changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65033664
Merging in master & branch-1.2. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65017766
[Test build #23967 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23967/consoleFull) for PR 3521 at commit [`16f41cd`](https://github.com/apache/spark/commit/16f41cd4413064e6f58a30d49b64cbc93f11c3cb).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65015029
[Test build #537 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/537/consoleFull) for PR 3521 at commit [`16f41cd`](https://github.com/apache/spark/commit/16f41cd4413064e6f58a30d49b64cbc93f11c3cb).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65039393
@zsxwing I know it's too late, but the cast should also have a `@SuppressWarnings("unchecked")`, ideally, to avoid another warnings. I have some things like this taken care of in another open PR: https://www.github.com/apache/spark/pull/3157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65022694
[Test build #23969 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23969/consoleFull) for PR 3521 at commit [`03cbe3f`](https://github.com/apache/spark/commit/03cbe3fd2797efa9db04c7e46e1d567dd2d32318).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65022700
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23969/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4661][Core] Minor code and docs cleanup
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3521#issuecomment-65017771
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23967/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org