You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/06 05:37:40 UTC

[GitHub] [flink] wangyang0918 commented on a change in pull request #13871: [FLINK-19544][k8s] Implement CheckpointRecoveryFactory based on Kubernetes API

wangyang0918 commented on a change in pull request #13871:
URL: https://github.com/apache/flink/pull/13871#discussion_r518533440



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/TestingRetrievableStateStorageHelper.java
##########
@@ -30,9 +34,28 @@
  */
 public final class TestingRetrievableStateStorageHelper<T extends Serializable> implements RetrievableStateStorageHelper<T> {
 
+	private FunctionWithException<T, T, IOException> retrieveStateFunction;
+
+	private RunnableWithException discardStateRunnable;
+
+	private Function<T, Long> getStateSizeFunction;

Review comment:
       Yes, we may need to change these functions. For example, we want to throw an exception when `retrieveState`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org