You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2020/01/12 14:37:35 UTC
[GitHub] [dubbo-go] codecov-io commented on issue #320: Mod: Change
MetricFilter so that we can specify the metrics which we want to collect
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/320?src=pr&el=h1) Report
> Merging [#320](https://codecov.io/gh/apache/dubbo-go/pull/320?src=pr&el=desc) into [feature/metrics](https://codecov.io/gh/apache/dubbo-go/commit/a58f6db53588c3830fd62e28e09ddc9d3ffef517?src=pr&el=desc) will **increase** coverage by `1.02%`.
> The diff coverage is `78.55%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/320?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/metrics #320 +/- ##
===================================================
+ Coverage 67.4% 68.42% +1.02%
===================================================
Files 133 138 +5
Lines 7908 8247 +339
===================================================
+ Hits 5330 5643 +313
- Misses 2098 2112 +14
- Partials 480 492 +12
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/320?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/320/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <ø> (ø)` | |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/320/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.4% <ø> (ø)` | :arrow_up: |
| [...l/tps/tps\_limit\_thread\_safe\_fix\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/320/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRfdGhyZWFkX3NhZmVfZml4X3dpbmRvd19zdHJhdGVneS5nbw==) | `100% <ø> (ø)` | |
| [filter/filter\_impl/tps\_limit\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/320/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwc19saW1pdF9maWx0ZXIuZ28=) | `88.23% <ø> (ø)` | |
| [filter/filter\_impl/graceful\_shutdown\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/320/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dyYWNlZnVsX3NodXRkb3duX2ZpbHRlci5nbw==) | `80.64% <ø> (ø)` | |
| [filter/filter\_impl/echo\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/320/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2VjaG9fZmlsdGVyLmdv) | `85.71% <ø> (ø)` | |
| [metrics/impl/default\_bucket\_counter.go](https://codecov.io/gh/apache/dubbo-go/pull/320/diff?src=pr&el=tree#diff-bWV0cmljcy9pbXBsL2RlZmF1bHRfYnVja2V0X2NvdW50ZXIuZ28=) | `82.14% <ø> (ø)` | |
| [...lter/filter\_impl/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/320/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `80% <ø> (ø)` | |
| [filter/filter\_impl/generic\_service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/320/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfc2VydmljZV9maWx0ZXIuZ28=) | `70.17% <ø> (ø)` | |
| [filter/filter\_impl/tps/tps\_limiter\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/320/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tb2NrLmdv) | `0% <ø> (ø)` | |
| ... and [51 more](https://codecov.io/gh/apache/dubbo-go/pull/320/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/320?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/320?src=pr&el=footer). Last update [a58f6db...0884c96](https://codecov.io/gh/apache/dubbo-go/pull/320?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo-go/pull/320 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org