You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by Abdel Hakim Deneche <ad...@maprtech.com> on 2015/02/19 04:28:27 UTC
merging pull request#6 with master
Hello parquet community,
my name is Hakim and I've been working to get pull request #6, #49 and #50
ready to merge with master.
So far I merged pull request #6 with master and all unit tests are passing,
I am still working to get #49 and #50 ready to merge (I actually got them
merged but I still have some unit tests that are failing).
You can find my changes for pull request #6 in my github repo:
https://github.com/adeneche/incubator-parquet-mr/tree/pull6-merged
Should I create a new pull request for this branch or should I contact the
author of pull request #6 to get my changes in his branch ?
Thanks!
--
Abdelhakim Deneche
Software Engineer
<http://www.mapr.com/>
Now Available - Free Hadoop On-Demand Training
<http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available>
Re: merging pull request#6 with master
Posted by Abdel Hakim Deneche <ad...@maprtech.com>.
Sound good :D
On Tue, Mar 31, 2015 at 9:22 AM, Ryan Blue <bl...@cloudera.com> wrote:
> Let's plan on talking about this at the sync-up in ~30 minutes?
>
> rb
>
>
> On 03/31/2015 08:16 AM, Abdel Hakim Deneche wrote:
>
>> Hi everyone,
>>
>> I just rebased my branch yesterday on top of master and it is ready to
>> merge:
>>
>> https://github.com/adeneche/incubator-parquet-mr/tree/pull6-merged
>>
>> Do we have an estimate when pull request #6 can be merged ?
>>
>> Thanks!
>>
>>
>> On Sun, Feb 22, 2015 at 6:10 PM, Jacques Nadeau <ja...@apache.org>
>> wrote:
>>
>> Hey everybody,
>>>
>>> I know that we people were pretty busy last week with Strata. Just want
>>> do
>>> a ping on this and see if someone can start looking through these
>>> changes?
>>> We have a number of enhancements we'd like to do and we want to work on
>>> them in master so everyone can get the benefit but we need to get this
>>> stuff merged first.
>>>
>>> Thanks!
>>> Jacques
>>>
>>> On Wed, Feb 18, 2015 at 7:28 PM, Abdel Hakim Deneche <
>>> adeneche@maprtech.com>
>>> wrote:
>>>
>>> Hello parquet community,
>>>>
>>>> my name is Hakim and I've been working to get pull request #6, #49 and
>>>>
>>> #50
>>>
>>>> ready to merge with master.
>>>>
>>>> So far I merged pull request #6 with master and all unit tests are
>>>>
>>> passing,
>>>
>>>> I am still working to get #49 and #50 ready to merge (I actually got
>>>> them
>>>> merged but I still have some unit tests that are failing).
>>>>
>>>> You can find my changes for pull request #6 in my github repo:
>>>> https://github.com/adeneche/incubator-parquet-mr/tree/pull6-merged
>>>>
>>>> Should I create a new pull request for this branch or should I contact
>>>>
>>> the
>>>
>>>> author of pull request #6 to get my changes in his branch ?
>>>>
>>>> Thanks!
>>>>
>>>> --
>>>>
>>>> Abdelhakim Deneche
>>>>
>>>> Software Engineer
>>>>
>>>> <http://www.mapr.com/>
>>>>
>>>>
>>>> Now Available - Free Hadoop On-Demand Training
>>>> <
>>>>
>>>> http://www.mapr.com/training?utm_source=Email&utm_medium=
>>> Signature&utm_campaign=Free%20available
>>>
>>>>
>>>>>
>>>>
>>>
>>
>>
>>
>
> --
> Ryan Blue
> Software Engineer
> Cloudera, Inc.
>
--
Abdelhakim Deneche
Software Engineer
<http://www.mapr.com/>
Now Available - Free Hadoop On-Demand Training
<http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available>
Re: merging pull request#6 with master
Posted by Ryan Blue <bl...@cloudera.com>.
Let's plan on talking about this at the sync-up in ~30 minutes?
rb
On 03/31/2015 08:16 AM, Abdel Hakim Deneche wrote:
> Hi everyone,
>
> I just rebased my branch yesterday on top of master and it is ready to
> merge:
>
> https://github.com/adeneche/incubator-parquet-mr/tree/pull6-merged
>
> Do we have an estimate when pull request #6 can be merged ?
>
> Thanks!
>
>
> On Sun, Feb 22, 2015 at 6:10 PM, Jacques Nadeau <ja...@apache.org> wrote:
>
>> Hey everybody,
>>
>> I know that we people were pretty busy last week with Strata. Just want do
>> a ping on this and see if someone can start looking through these changes?
>> We have a number of enhancements we'd like to do and we want to work on
>> them in master so everyone can get the benefit but we need to get this
>> stuff merged first.
>>
>> Thanks!
>> Jacques
>>
>> On Wed, Feb 18, 2015 at 7:28 PM, Abdel Hakim Deneche <
>> adeneche@maprtech.com>
>> wrote:
>>
>>> Hello parquet community,
>>>
>>> my name is Hakim and I've been working to get pull request #6, #49 and
>> #50
>>> ready to merge with master.
>>>
>>> So far I merged pull request #6 with master and all unit tests are
>> passing,
>>> I am still working to get #49 and #50 ready to merge (I actually got them
>>> merged but I still have some unit tests that are failing).
>>>
>>> You can find my changes for pull request #6 in my github repo:
>>> https://github.com/adeneche/incubator-parquet-mr/tree/pull6-merged
>>>
>>> Should I create a new pull request for this branch or should I contact
>> the
>>> author of pull request #6 to get my changes in his branch ?
>>>
>>> Thanks!
>>>
>>> --
>>>
>>> Abdelhakim Deneche
>>>
>>> Software Engineer
>>>
>>> <http://www.mapr.com/>
>>>
>>>
>>> Now Available - Free Hadoop On-Demand Training
>>> <
>>>
>> http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available
>>>>
>>>
>>
>
>
>
--
Ryan Blue
Software Engineer
Cloudera, Inc.
Re: merging pull request#6 with master
Posted by Abdel Hakim Deneche <ad...@maprtech.com>.
Hi everyone,
I just rebased my branch yesterday on top of master and it is ready to
merge:
https://github.com/adeneche/incubator-parquet-mr/tree/pull6-merged
Do we have an estimate when pull request #6 can be merged ?
Thanks!
On Sun, Feb 22, 2015 at 6:10 PM, Jacques Nadeau <ja...@apache.org> wrote:
> Hey everybody,
>
> I know that we people were pretty busy last week with Strata. Just want do
> a ping on this and see if someone can start looking through these changes?
> We have a number of enhancements we'd like to do and we want to work on
> them in master so everyone can get the benefit but we need to get this
> stuff merged first.
>
> Thanks!
> Jacques
>
> On Wed, Feb 18, 2015 at 7:28 PM, Abdel Hakim Deneche <
> adeneche@maprtech.com>
> wrote:
>
> > Hello parquet community,
> >
> > my name is Hakim and I've been working to get pull request #6, #49 and
> #50
> > ready to merge with master.
> >
> > So far I merged pull request #6 with master and all unit tests are
> passing,
> > I am still working to get #49 and #50 ready to merge (I actually got them
> > merged but I still have some unit tests that are failing).
> >
> > You can find my changes for pull request #6 in my github repo:
> > https://github.com/adeneche/incubator-parquet-mr/tree/pull6-merged
> >
> > Should I create a new pull request for this branch or should I contact
> the
> > author of pull request #6 to get my changes in his branch ?
> >
> > Thanks!
> >
> > --
> >
> > Abdelhakim Deneche
> >
> > Software Engineer
> >
> > <http://www.mapr.com/>
> >
> >
> > Now Available - Free Hadoop On-Demand Training
> > <
> >
> http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available
> > >
> >
>
--
Abdelhakim Deneche
Software Engineer
<http://www.mapr.com/>
Now Available - Free Hadoop On-Demand Training
<http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available>
Re: merging pull request#6 with master
Posted by Jacques Nadeau <ja...@apache.org>.
Hey everybody,
I know that we people were pretty busy last week with Strata. Just want do
a ping on this and see if someone can start looking through these changes?
We have a number of enhancements we'd like to do and we want to work on
them in master so everyone can get the benefit but we need to get this
stuff merged first.
Thanks!
Jacques
On Wed, Feb 18, 2015 at 7:28 PM, Abdel Hakim Deneche <ad...@maprtech.com>
wrote:
> Hello parquet community,
>
> my name is Hakim and I've been working to get pull request #6, #49 and #50
> ready to merge with master.
>
> So far I merged pull request #6 with master and all unit tests are passing,
> I am still working to get #49 and #50 ready to merge (I actually got them
> merged but I still have some unit tests that are failing).
>
> You can find my changes for pull request #6 in my github repo:
> https://github.com/adeneche/incubator-parquet-mr/tree/pull6-merged
>
> Should I create a new pull request for this branch or should I contact the
> author of pull request #6 to get my changes in his branch ?
>
> Thanks!
>
> --
>
> Abdelhakim Deneche
>
> Software Engineer
>
> <http://www.mapr.com/>
>
>
> Now Available - Free Hadoop On-Demand Training
> <
> http://www.mapr.com/training?utm_source=Email&utm_medium=Signature&utm_campaign=Free%20available
> >
>